[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86emul/test: drop bogus .PHONY
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 5 Apr 2023 16:48:38 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 05 Apr 2023 15:49:14 +0000
- Ironport-data: A9a23:GsIbL6CCPiJTIRVW/yHjw5YqxClBgxIJ4kV8jS/XYbTApGwghGBSz mRMWTjVOazYZmT3KN9xPN6w8UwO6JOEyoJkQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4G9A4wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5+JeKmZu2 tokISlVUzCD2eOanrm6Vbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4TRH54Oxh7Fz o7A1zm6OU8eacOm8zSUrW+iurDFwCnUG6tHQdVU8dY12QbOlwT/EiY+V1G2vP24gU6WQM9EJ gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xGWwsXjNHLts8u6ceTCQnz FaTk/v1BDZkt/ueTnf1y1uPhWrsY25PdzZEPHJaC1JfuLEPvb3fkDrSSv9IF46aqOH8AGnN4 zDUrQRgjLQM2JtjO7qAwbzXv969jsGXHlZrt12GAD3NAhBRP9D8OdHxgbTPxbMZddvCEAHc1 JQRs5LGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuKGpxeEdMRS BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QeOsYqL1XWp3E/PSZ8OlwBd2B1yMkC1 WqzK57wXR7294w8pNZJewvt+eBynX1vrY8ibZv60w6mwdKjWZJhcp9caAHmRrlgvMu5TPD9r 4432z2il08OD4UTo0D/reYuELz9BSNhX8yn8JAKK7Xrz8gPMDhJNsI9CIgJI+RN95m5XM+Sl p1hcie0EGbCuEA=
- Ironport-hdrordr: A9a23:ihJHs6Gzj/JunA9MpLqEHseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV86faQslwssR4b9uxoVJPvfZqYz+8W3WBzB8bEYOCFghrKEGgK1+KLrwEIWReOk9K1vZ 0KT0EUMqyVMbEVt6fHCAnTKade/DGEmprY+9s3GR1WPHBXg6IL1XYINu6CeHcGPTWvnfACZe ehDswsnUvZRV0nKv6VK1MiROb5q9jChPvdEGI7705O0nj0sduwgoSKaSSl4g==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 04, 2023 at 08:37:55AM +0200, Jan Beulich wrote:
> x86_emulate is a real (directory) target.
Indeed, x86_emulate is a directory, so having the target in .PHONY
isn't bogus, but kind of expected in most cases.
Here, the recipe is written with .PHONY been used, as suggest the used
option "-p" from `mkdir` and "-f" from `ln`.
Without .PHONY, the recipe will never be executed if the directory
exist. And, if the content of the original x86_emulate directory
change, the linked directory will never be updated.
So, this patch description needs a reason for removing x86_emulate from
.PHONY. Is there some kind of bug?
> --- a/tools/tests/x86_emulator/Makefile
> +++ b/tools/tests/x86_emulator/Makefile
> @@ -278,7 +278,6 @@ else
> run32 clean32: %32: %
> endif
>
> -.PHONY: x86_emulate
> x86_emulate:
> mkdir -p $@
> ln -sf $(XEN_ROOT)/xen/arch/x86/$@/*.[ch] $@/
Cheers,
--
Anthony PERARD
|
