[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 6 Apr 2023 11:31:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9L2hFRv6P4F0H7tzS8f0dl8uOz+tEs6WwzZa6b6gSKs=; b=nXV2A2i6P+hMU4lbN/Yp6U51DBK5FNU9CXz02XFhvEe3RgWFVy8rr9nWS+RTaqI13Z1c5qdKMUstGhIA/gA0MbCXI0GXdrUxsF6xA/nuzoLTVcUxCB3RCoLLgfzP9rU/oTe7Y6LRKrs/RMK2iJVfFIbByQqnYnpPlxk4LMJJjO2rlPOXA1OWuJ+ORPIbFYJ89tQ9+VxuyMvf0C5yXvFV0gUXAVrMei0bJOr9UKHYt3gBB5s0XfCtWJfwIB/55NXwbQUsG2Uif0SdMODeKaf0pmu2+ejWfsFgfdkwfgva+i6Q06aWR7UwiWNaQZfJzaOLieQhqE1S+8ho+5f0T45usQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RjJ5lKuGzxJuKMynp6s9tI0FCv0ig1su6zgBMKdjBtkQ8YKf3DGlk6mIaBFLzudZDP61QN1g03oegdIGYRJsm0ditPz5/fAq91NuJ7JRtePOuPXWmdGBtU4ebA3J4ICKx++XFnzOf71mH8n7mAKStkfk9B1dtkEz6DCqrnSBcBdS/KFH6rjksfh6U8zxu9Xca7g43FhqgcmR4fTzONlND64SlypI10/jHbdkydyRvMv9IzdIvN1KIr2kWR8+fsuOgbFC6izlIZSzErwQj8JEw6Xt+dtXmyRzdOBXtWO5LHe4oFj18jNQCNH4J0ciV65ik1xhQVJx1cQqCzlL37Ai8w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 06 Apr 2023 09:32:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.04.2023 22:44, Andrew Cooper wrote:
> This removes raw number manipulation, and makes the logic easier to follow.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
One remark though:
> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h
> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h
> @@ -450,6 +450,11 @@ struct vmcb_struct {
>
> uint64_t nrip;
> } io;
> + struct {
> + uint64_t gpr:4;
> + uint64_t :59;
> + bool mov_insn:1; /* MOV, as opposed to LMSW, CLTS, etc */
> + } mov;
The field being named just "mov" makes it apparently applicable to DRn
moves, too (and the title supports this), yet the top bit doesn't have
this meaning there. So perhaps say "MOV-CR" (or alike) in the comment?
Jan
|
