[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH AUTOSEL 5.4 9/9] xen/netback: use same error messages for same errors



From: Juergen Gross <jgross@xxxxxxxx>

[ Upstream commit 2eca98e5b24d01c02b46c67be05a5f98cc9789b1 ]

Issue the same error message in case an illegal page boundary crossing
has been detected in both cases where this is tested.

Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Link: https://lore.kernel.org/r/20230329080259.14823-1-jgross@xxxxxxxx
Signed-off-by: Paolo Abeni <pabeni@xxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
 drivers/net/xen-netback/netback.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/xen-netback/netback.c 
b/drivers/net/xen-netback/netback.c
index 3dfc5c66f1408..a3078755939e3 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -989,10 +989,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue 
*queue,
 
                /* No crossing a page as the payload mustn't fragment. */
                if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) {
-                       netdev_err(queue->vif->dev,
-                                  "txreq.offset: %u, size: %u, end: %lu\n",
-                                  txreq.offset, txreq.size,
-                                  (unsigned long)(txreq.offset&~XEN_PAGE_MASK) 
+ txreq.size);
+                       netdev_err(queue->vif->dev, "Cross page boundary, 
txreq.offset: %u, size: %u\n",
+                                  txreq.offset, txreq.size);
                        xenvif_fatal_tx_err(queue->vif);
                        break;
                }
-- 
2.39.2




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.