[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status when backend in Xen
- To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 12 Apr 2023 06:55:11 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iVWSCWaPCaSF2F5CYJf465h0SbWQLJccfkSY+GBw/Bc=; b=QvBCQV1mY19LAH0LB9i7KUq8Cfuc1PeT6Ck7Ex+8vhyzoKXL8CRzrSe7M6RFIOplwd4kT6cnEMMptegnaPfIUlkbIvfFljaAzRqRUEX+L5W443/u9AE/apGoM9PJsxWrfeySIwiCLSOPrZjQuMnozv3yJ6PpaPL5ulR0zju9K3pgFHrcpR211Ms0mjnXM4ndj+jNGK39JvN5ckFvYek4R9BAFoghZsxPLh+6kzXJwo9m8S7OyM4ZcDLSW0FL+no31JUOw9ykwj41PM3GlDmB/ZfpznJMDn7BuGDFi4fylvWv4MxifQBIEV1Wb5XpwcKJNuj1jMJPXW6UtT2coPIrUw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oKHN3oBp9P3+6EHVHS5ZEXDL0F7wNLgdr3HWV0kq3Ip20LhJyu7D+dZLjoTTc13RJtUMqrewef5LzQquDnMt5vOpS1ZzTBW362EApfoDxBFrSGfV2TEYqxLs5q5hf7Lx7A80UiU7+XVLRIEaNVFJMpoRSPMUzUUH6hr6RffwiSOVB7O/MfqTKAJSPhLQtAOiJ6eWQBswKsiF3kcGiyTKUaZEsN70FxqqrNPtKcM+1xLlYPqxDLamsGdlrqDnfx9VCZyKTzPNQ0UkIVsUHXWDXRevirONE4DDsM3jfuWV51X6b4xOiEr8fYGBzObD9iYbIHG7IF8QdiWlbMKd75bImA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 12 Apr 2023 06:56:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZZ7BhM9d/TecBu020qzDpPrY4KK8nPD6g
- Thread-topic: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status when backend in Xen
Hi Michal,
> -----Original Message-----
> Subject: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status
> when backend in Xen
>
> From vpl011_rx_char_xen(), we call vpl011_data_avail() that handles both
> RX and TX state. Because we are passing 0 as out_fifo_level and
> SBSA_UART_FIFO_SIZE as out_size, we end up calling a function
> vpl011_update_tx_fifo_status() which performs TXI bit handling
> depending on the FIFO trigger level. This does not make sense when backend
> is in Xen, as we maintain a single TX state where data can always be
> written and as such there is no TX FIFO handling. Furthermore, this
> function assumes that the backend is in domain by making use of struct
> xencons_interface unconditionally. Fix it by calling this function only
> when backend is in domain. Also add an assert for sanity.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
I've tested the patch by manually running the XTP on FVP_Base, and this
patch works fine. So:
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
