Re: [QEMU][PATCH] gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen

[Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>]

On 12/4/23 07:39, Thomas Huth wrote:
> On 11/04/2023 23.04, Vikram Garhwal wrote:
> > Xen is supported for aarch64 via xenpvh machine. disable-tcg option 
> > fails the
> > build for aarch64 target.
> >
> > Link for xen on arm patch series: 
> > https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html
> > Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
> > ---
> >   .gitlab-ci.d/crossbuilds.yml | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
> > index 61b8ac86ee..6867839248 100644
> > --- a/.gitlab-ci.d/crossbuilds.yml
> > +++ b/.gitlab-ci.d/crossbuilds.yml
> > @@ -186,7 +186,7 @@ cross-amd64-xen-only:
> >     variables:
> >       IMAGE: debian-amd64-cross
> >       ACCEL: xen
> > -    EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm
> > +    EXTRA_CONFIGURE_OPTS: --disable-kvm
> >   cross-arm64-xen-only:
> >     extends: .cross_accel_build_job
> > @@ -195,4 +195,4 @@ cross-arm64-xen-only:
> >     variables:
> >       IMAGE: debian-arm64-cross
> >       ACCEL: xen
> > -    EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm
> > +    EXTRA_CONFIGURE_OPTS: --disable-kvm
> This patch looks wrong. I'm pretty sure we wanted to test the build 
> without TCG here. Building with TCG enabled is already done in other 
> jobs. So instead of removing "--disable-tcg" here the question is 
> rather: Why does it not build with this flag anymore? Can those problems 
> be fixed instead?
I concur, this used to work. Did this config bit-rotted?
The latest /master job succeeded:
https://gitlab.com/qemu-project/qemu/-/jobs/4094506462