[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET


  • To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Thu, 13 Apr 2023 11:07:04 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fJWgnlrg0Wg4hkIVgIUCJl1zVVBS0VE1HQf7JQV7XmE=; b=j6HlG/SHaxh/tVVfEbLbKIpk1FfzQ6YCqIiOiMTFNa0nT2nN2jzn5yvnaRfzFFeZrJZD1nxjKDZGlJnvGPRwrMTMCMIJtBgz9vlROUYYeiuUJy+R8NTLPSrb/MuQd2jXy/COLh1//0reAt7ejheRIh97FiROYgbj1KqlurTZL/3dOID0Gm8ma++mM7cllr5XvFM6O4t4nriEkKhM5WZSDdmT9SjFjgiWCDbUBuI+tpSZEQ6/6Te9mbWZj+wdsVnj7ixJD4lc7hWWQi8B1c2/1J3WinSW1LwJjwHF/aqzEJLsGikUO+pOmTQokDtZwOw0KWN/tt7zmeb7KdeZTB+ghw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYxpVoQiolbrAZwtaaG74oJOTiGlSQcF/CcrnGTGPeFdcfKgdJ5aoWa6ub2V0d3LHzbmyYjG+ODUfaywRcohSRBVF+TcWeJVGg4tb0QGhCHt8O22FbTQ+wkR2KcLZufEfx/TEngKVIFdK97UTh6r7Rw7d+k5s6e6ciwpVmMNe5BDgkmEHKIuYt+C0YRDxWRnWZcEda04XugUlZFVxniz80EmGT6w+c7OtIysGnFrtl64JcAxjYWQgQ6zePNRLxPQSKeNkUF2Aq0EYxPfTYtrjjhPpKdwDxfTL7oX5dcLTpCBnnVC2yFIELlWxOJKZiM1ujJUX7Nksqo1TM7mEJavXQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Marc Bonnici <Marc.Bonnici@xxxxxxx>, Achin Gupta <Achin.Gupta@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Delivery-date: Thu, 13 Apr 2023 11:07:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZbdfdlkWasQb0b0OUu0VnJOxcoK8pEVxw
  • Thread-topic: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET

Hi Jens,

> -----Original Message-----
> Subject: [XEN PATCH v8 08/22] xen/arm: ffa: add support for FFA_ID_GET
> 
> Adds support for the FF-A function FFA_ID_GET to return the ID of the
> calling client.
> 
> Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
> ---
>  xen/arch/arm/tee/ffa.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
> index 90ed71cbfda3..f129879c5b81 100644
> --- a/xen/arch/arm/tee/ffa.c
> +++ b/xen/arch/arm/tee/ffa.c
> @@ -181,6 +181,12 @@ static bool ffa_get_version(uint32_t *vers)
>      return true;
>  }
> 
> +static uint16_t get_vm_id(const struct domain *d)
> +{
> +    /* +1 since 0 is reserved for the hypervisor in FF-A */
> +    return d->domain_id + 1;

Since here you want 0 to be reserved, I think maybe you can use
the "d->arch.p2m.vmid"? According to the logic in p2m_alloc_vmid(),
the "d->arch.p2m.vmid" is also a per-domain u16 value that starts
from 1.

Kind regards,
Henry



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.