Re: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework direct request/response messages

[Jens Wiklander <jens.wiklander@xxxxxxxxxx>]

Hi Henry,

On Thu, Apr 13, 2023 at 12:51 PM Henry Wang <Henry.Wang@xxxxxxx> wrote:
>
> Hi Jens,
>
> > -----Original Message-----
> > Subject: [XEN PATCH v8 06/22] xen/arm: ffa: add defines for framework direct
> > request/response messages
> >
> > Adds defines for framework direct request/response messages.
>
> Same here, it actually took me a while to find the related chapters
> about this patch, so I would suggest that we can add more details
> about where the values are from.
>
> From the spec that I referred to (DEN0077A version 1.1 REL0), they are
> in section 18.3, Table 18.{21, 25, 26, 27,28}.

OK, I'll add it.

>
> >
> > Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
>
> I confirm the values introduced by this patch are consistent with the
> above spec, hence:
>
> Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>

Thanks,
Jens

>
> Kind regards,
> Henry