Re: [PATCH v5 02/12] xen/arm: add SVE vector length field to the domain

[Julien Grall <julien@xxxxxxx>]

Hi Luca,

On 13/04/2023 17:10, Luca Fancellu wrote:
> > > > > Can we move this somewhere else to avoid adding extra padding? Also shouldn't 
> > > > > this be protected with #ifdef CONFIG_ARM_64 to make clear this is not supported 
> > > > > on Xen 32-bit?
> > > > Yes, I’ll move it and protect with CONFIG_ARM_64, is it ok for you if I move it 
> > > > after:
> > > > /* Monitor options */
> > > > struct {
> > > >     uint8_t privileged_call_enabled : 1;
> > > > } monitor;
> > > Please check the padding with "pahole". If possible, it would be better to 
> > > re-use an existing one.
> > Ok I’ll try to use the tool
> I’ve managed to use the tool, the field seems already in a good spot:
ok. Thanks for checking.

Cheers,

--
Julien Grall