[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 14 Apr 2023 01:50:45 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/0dmwobpMlHVyKGJ4RopLZFrcAb9z2gbFSUg5A+kZq8=; b=EeUPKXccVowS5jzkRYbk3M9MfqdAslyt9LThgi+qV4X620mPzP7xRp34U96FB67zPjd7ruTv8U0ISO1g2FRpU9bhCmXZIxpr9qJjkgxkh29EbFU7aW/KKkgXaVqf0lyjrcBaE5oC8wqH7eVD9jMTALfpE0AKYdNiO1Pys2pOAX4s6pXjoTEWMp7CThfVCj0GC/P0B/VgbK8skrN01jffub/UfHvcFU1E64irLP5u9cqcSLL14F6eWB5I6xOmfxvfCfQBwTH87955gwxZY3vOh6QJOlHSdhKdVflMwmfV1RGaAOGLFWdtsjvdZ+bdlU4gbeERKpphsO1r56pjOOAafg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KxAxwgyYdWGjNAr/KqvArb3R/HiCqL3tqQu9U05MsJt9qALETe8epFwUcWY8c+B8jgMjhCLBeEHHBc5llxreKsTolKBavWGl/fYGZqEX72ZcOjVjUHEaLG0IQ46hO/67zL7ZDnaI27+OuxTRGIJnbQ+2RC32lF1Do8sB9d5CbhpKe6s0gz0B276zrKim4O342ufjOReRV6pH5Y6P3i8bZE/bfewXCf/Y01muSYcvZSHQKiKObY7Im2eie8kKlpXEm1ajkbcFFric650wStVAxBdpy7ShRlqLnS4YvTOAkfR0LRnmnhbI4NvKVB7xjq5Jge1W0AK6oEc9qLxHwzNbTw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 14 Apr 2023 01:51:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZbKpEgTyA0CRuYk66qjVY5D36Ua8qDYcw
- Thread-topic: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h
Hi Vikram,
> -----Original Message-----
> Subject: [XEN][PATCH v5 11/17] asm/smp.h: Fix circular dependency for
> device_tree.h and rwlock.h
>
> Dynamic programming ops will modify the dt_host and there might be other
> function which are browsing the dt_host at the same time. To avoid the race
> conditions, adding rwlock for browsing the dt_host. But adding rwlock in
> device_tree.h causes following circular dependency:
> device_tree.h->rwlock.h->smp.h->asm/smp.h->device_tree.h
>
> To fix this, removed the "#include <xen/device_tree.h> and forward declared
> "struct dt_device_node".
>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
