[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 15 Apr 2023 04:58:10 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KrA8IWKKeeFG1W6ZwODIRDwRgiC2u6YdYMqxGQUzm+o=; b=PoMstpCu/sgGcSt0zb2x8VJED3l9I3I9zt6BcfPZUI7peaHsAN7EYG6JzptDQwZctBHT2Ul3DWn9qQple7549qfWvv/op1as+fUJWBnbeFraEjTV9g6hcHQbVVxHR8SG6pCrkjzx1KIakrViIC4DN8HBMdgpE2YTZWdsAR8YiWPl1iPSqDIPNN1Oz4JTK4zcaPTEzo06mYQm3SjDFVIJ5MfGfTxGvqYTZV85v32OC9ZajMojSlclkw4YiGIag/lbIv+M8TsRUOJOz4oSMDTS3CX42Bh5ojHCvV8MejhnrPmu5ccb3pifru9Aa/xe+8k3/jes3SCSY2F4kWRg8EH5zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g4a3+jcFMIgHiG6inAn23eq7VZsLQrTlxxRrVXbGo4ggRBdMCpEQodGQozjdfiSn9DsDQ7WOhg/eTaM6jyk1V1CjE74JinKwpIgvipIY2cEm6IxJUwrZl6HpHjs1+7gLZQlwy8Oc9hJZ5fLILLMzrsUks7ofhUXUttA1GU0j9eVMUn1fcsTABV3wRx9NowgVnFcDbfyF55WGh7akwNJsGwjgSYS8iVndodf1tH3e0blp8OqpmUEWkQnWMs7y6iCke4GQVWmG2WTtRnHO/Uw8eeNn52SDp+4XR+1+EIXfk/iRSJ+CJFHHn9QWjl8jNRa8DMPGgFYAO0YdiLtVHE0KCQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Sat, 15 Apr 2023 04:59:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZbwMWeR0W8wxF2kqEL5lhRIkFbK8rm8pA
- Thread-topic: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline
Hi Stewart,
> -----Original Message-----
> Subject: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline
>
> When building the hypervisor with -Og, we run into a __bad_cmpxchg link
> error:
>
> aarch64-none-linux-gnu-ld: prelink.o: in function `__int_cmpxchg':
> .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference
> to `__bad_cmpxchg'
> aarch64-none-linux-gnu-
> ld: .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined
> reference to `__bad_cmpxchg'
> aarch64-none-linux-gnu-ld: ./.xen-syms.0: hidden symbol `__bad_cmpxchg'
> isn't defined
> aarch64-none-linux-gnu-ld: final link failed: bad value
>
> This is due to the function __guest_cmpxchg not being inlined in the -Og build
> with gcc 12. Fix this by marking __guest_cmpxchg always_inline.
>
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx
Hmmm I think you missed the ">" in the end of your signoff...But anyway the
patch looks good to me so:
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
