[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] xen/arm: mark __guest_cmpxchg always_inline
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Sun, 16 Apr 2023 21:56:09 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CWdT4+fYncLA3IivelBA4rg96u9zi5g/rldo/VCvoS8=; b=CtAdh902PevljIBMiwW1+G6V9zcYzG/7//Whp8/tnUexP8TgUj8I4We9MR+cpRNqHSIQULzC50NVaUU/wpvsFpqaMnKe4g/PPIBrmzGVUztxwTZt6XafLzQZB8hj7//Jas1Lx676tXv5niWmmILtizB1121NSf3Lv+qbPVww9T6ITwt305ra4YEuQRDdJaa9D4yG83MQX1A3fyzwlsGCv7Eh+4n7V1G2Qh3lyaNcPwS+i83usbjlPbQJ21Lq9Rdd1qIQXB0yQEr84JW0pW2QSlyzFKtQEHc0/OrDGQjOK4vqfg0KGIzqYdV98EPI40RSuEzJ+svP4Sucg3NHRoNFfw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d6h8uEcyrXaSqE7NLvJr78YzvVRWmVlDte/7ccNjxlmZIi4zOJSsYW05cTG1rwhlyGqFKbRpa/laPwOxR3J2iT5Elo/oQfq6qfX7rGdi/Xgdlg0eD39hn68Dw2jbioI+o/Mi/g2dv3aL0dMM3ptUJREOZLSsQyn9QxTwh4uch8nc9zaJTNPi9Iu+Lbz6asar9NIGPSwUMD2stGujzledz0+vgddT4SugiT0OFE379H8ZWnXfmv9NMaCBbyq4Bue3sYkZXKJcGkovyczB1l1VoQDOld4jclSNJXrfkVty9cDxD6/mgMxwIeXji6Yc5YjhPp5NbUCLnNHSgNKxewwhbg==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Mon, 17 Apr 2023 01:56:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 4/16/23 08:50, Julien Grall wrote:
> Hi Stewart,
>
> On 14/04/2023 19:57, Stewart Hildebrand wrote:
>> When building the hypervisor with -Og, we run into a __bad_cmpxchg link
>> error:
>>
>> aarch64-none-linux-gnu-ld: prelink.o: in function `__int_cmpxchg':
>> .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference to
>> `__bad_cmpxchg'
>> aarch64-none-linux-gnu-ld:
>> .../xen/./arch/arm/include/asm/arm64/cmpxchg.h:117: undefined reference to
>> `__bad_cmpxchg'
>> aarch64-none-linux-gnu-ld: ./.xen-syms.0: hidden symbol `__bad_cmpxchg'
>> isn't defined
>> aarch64-none-linux-gnu-ld: final link failed: bad value
>>
>> This is due to the function __guest_cmpxchg not being inlined in the -Og
>> build
>> with gcc 12. Fix this by marking __guest_cmpxchg always_inline.
>>
>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx
>> ---
>> I considered also changing "guest_cmpxchg64" just below in the same file to
>> always_inline, but I decided not to because this function does not take a
>> size
>> parameter.
>
> Make sense. I will fixed the signed-off-by line issue reported by Henry
> while committing:
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thank you!
|
