[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 2/5] xen/arm64: Rework the memory layout


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Mon, 17 Apr 2023 07:21:27 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cavBQbLHMJ0mRw8PT5sgIG/4b6X42jfw8a0tN06yiXA=; b=JRSbcjxiw9ZXJE94U1s9fa2CohyCpX6Fh6AyNUh6xJmOyxnhOI/DVeVzDoJzwqGIu6a9ODVtxe2NKBKueYjm9uuvbBccU+VLT0fH39jE4jCdD867H8fHbHPlOaDqGzQl75wXP343lvQJdJXgE8TJfRCSXmposBhncHWcmOEiJ9jnBAtcnlOC/B7s39yf8IlHg4DxEDf1wiUMRrsCSfH3BzSILJMG/0pZTbd1lGeqb4iC65kYBAzmbLxYgxr3i1tIDDOGCwKvTwN/j1Pwigl3j2GaSFEUlkBo7EiZPcMmBPXUmSwiCzCqI4tUz4x2jjAt0kIjfH3487b368iX7XVsRA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=InrLjsVg9nZWtrygfBYthw88FAAWAeq23K4DjieBdo8N62NElMCoC5/Nv1R1eq4UX4INwz77BX2yYrWmiydvFFwNzIeXjb369Q+raq0cAzuP+vM1GrGBHB4zut9gdRM6NqTDg0mia6G4aNmqJ1YRgi1v62n5Yx369qIt1z/fDM/oQGEzSSAbz6lrXG41UeS0k4dXdIe2j53TZZC9RTqhuVFEDjogl+TfGgTKgqCyYkMyAw2wBbqy9zVNjPz9/Qnyxu2Ze75TSB0rpHTIJr9UU+d75C9pNJWRLGG3aapex+GtPt05oLdeipAFIKN/bQfYWyR4q61H99Dmzp7R8LVpag==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 17 Apr 2023 07:22:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZcHBTTmBJ360YB0mwtleUAbK62a8vGYQA
  • Thread-topic: [PATCH v7 2/5] xen/arm64: Rework the memory layout


> On 16 Apr 2023, at 15:32, Julien Grall <julien@xxxxxxx> wrote:
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Xen is currently not fully compliant with the Arm Arm because it will
> switch the TTBR with the MMU on.
> 
> In order to be compliant, we need to disable the MMU before
> switching the TTBR. The implication is the page-tables should
> contain an identity mapping of the code switching the TTBR.
> 
> In most of the case we expect Xen to be loaded in low memory. I am aware
> of one platform (i.e AMD Seattle) where the memory start above 512GB.
> To give us some slack, consider that Xen may be loaded in the first 2TB
> of the physical address space.
> 
> The memory layout is reshuffled to keep the first four slots of the zeroeth
> level free. All the regions currently in L0 slot 0 will not be part of
> slot 4 (2TB). This requires a slight tweak of the boot code because
> XEN_VIRT_START (2TB + 2MB) cannot be used as an immediate.
> 
> This reshuffle will make trivial to create a 1:1 mapping when Xen is
> loaded below 2TB.
> 
> Lastly, take the opportunity to check a compile time if any of the
> regions may overlap with the reserved area for identity mapping.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> 

Hi Julien,

It looks fine to me.

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.