[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v5 05/10] xen/arm: Introduce choice to enable 64/32 bit physical addressing
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 17 Apr 2023 11:15:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p4de9NDZRmdkzw9W0oswOUd/6ehBsF9MdD78XRX5yJg=; b=eOu4YyOe46cJgj2yOjRfqOeIA0iWZktQW77Sviuan8yfH7zagSdpWpmgv5LMNMx8daKi6K8h9NEFB1P4Xi3zQItKCbys/Glh/1xoAIv8v7Q9oqiRNqeozIDYgKIBjTkWQnKT5y/D72wet+VJYvJcCym26pK4z7LtWOyKUA4SGpjnuirp+0y5zCS9D6knpea9vswo+0vFgmnKFtPZFLrmyw4RZWH6PTm3AnFQJ7wV1EP78auXBrQROfIKjqbTHhV4zyJBxEtVOblu2hX+FLPVWT4olP8sra5bNvaax4bwnEfwMAP6rgjasz6lDbSHiVPySnyQS8sh7Yp9xC2fGxnAIQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gnjJmB3R4AAMYUiiu7B3CnLfvFtdogY01D0Qy2yXdlJ4FeIrftT9PH2Z0K/Q1k1eQcuSGKXiA8HItqJuI8OQOrV8al3RlkUixo89j+Ylaze0iJwDx4lzGbQnjQP7rm5QktuGoMIv15yxp/hOZwA8HbZLhw9Qw9eAjf9lhWM8Kx/dxQMIS8Jo7HnNd2iuJjIZ6PwTYJGe1A9KQQjjWw1FyRggVWClxT2FHilPzZmxbmBYjazCVQXPBPKtTixX3g1wbfuSPrGV9ItFgpt2UfqeBIdtQGnzDublHML3rBP+YRQ6lJmto89HHQ6poCSmxLW7nbxsihiOcXuTOgaK5AOtUA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, stefano.stabellini@xxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, wl@xxxxxxx, rahul.singh@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 17 Apr 2023 09:15:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.04.2023 19:37, Ayan Kumar Halder wrote:
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -19,13 +19,46 @@ config ARM
> select HAS_PMAP
> select IOMMU_FORCE_PT_SHARE
>
> +menu "Architecture Features"
> +
> +choice
> + prompt "Physical address space size" if ARM_32
> + default ARM_PA_BITS_48 if ARM_64
> + default ARM_PA_BITS_40 if ARM_32
> + help
> + User can choose to represent the width of physical address. This can
> + sometimes help in optimizing the size of image when user chooses a
> + smaller size to represent physical address.
> +
> +config ARM_PA_BITS_32
> + bool "32-bit"
> + help
> + On platforms where any physical address can be represented within 32
> bits,
> + user should choose this option. This will help is reduced size of the
> + binary.
> + select PHYS_ADDR_T_32
> + depends on ARM_32
May I suggest that "help" come generally last, and preferably "depends on"
before "select"?
Jan
|
