[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/livepatch: Fix secure_payload() in non-debug builds
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 17 Apr 2023 12:41:38 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R2VvzppRbmXMivGi/k2XbuKnAJw7QqsWC5xHrhvSiBs=; b=b7+eKypfvMVVaKJfsRSyh4MAjomvd07r3ta7ero47nUwQze2Gf7+xPgKE/Mv0rCpCTHBfmZ1zhmQ28smq65AnooyNzjgikpZKIOOILFF6wFwZTh6r7JuYzo6A+fG0ShkGkuLWJAxB5CVf5Nwhin1RewjHPBHknWkZXoSpAXvBZV3x9KKpujGc6cn6vfpQf9iFVcoV6qVMRN1Z20kRCGJGwGx3spTyZ9q2e8SAe1YN9lf/MDPczyKUuEt2jghF2FtDjurZSpKN9TCXISnPC0fidHLtZ7xDehTyQ4E/eWFC2nwJK9MRepxzPH0XZgk/ycSKD0VUrXfeDtwfN4qdCSF8A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CXEB6ULl+4gfQW+/b988wPvho+lnD4bCa+7cJGrw7AuS+I5+raN8yPOj4HsgQm96/vl7U9EEjE8uEHndj95sTuCabZf0pebUqa05Pk9Ey78sSG8+9XrnB1rVuGYBvxIw+/EXN1QIBLtwIzdr8raj9jb0QMU4LNywflrFl4yt0hgxJR51cxDbO/TCKP+wU7VpeZmTMxmZOAW6eE/Gi0Sd43I5LIyTUDLi5zSSmBWEyWhj8AgJeMsURseuTWf/Zz3Yg+JKbwruKA6YshyPAQMKTUmbTE+hOUjTOs90kMTzURE1heS5pJyhGPXz+BvcHRJOYY+wytWjCHjXYAB1cRlqsg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 17 Apr 2023 10:42:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.04.2023 11:58, Andrew Cooper wrote:
> The ro_pages + rw_pages + text_pages != payload->pages check is not something
> which is reasonable to skip at runtime. Rewrite it to not be an ASSERT().
Isn't this merely a sanity check? IOW isn't returning -EINVAL in this case
misleading, as to calling "invalid input" what really is an internal error
in Xen? But anyway, I guess I'll leave this to the maintainers.
> As the code is being shuffled anyway, rework the logic calling
> arch_livepatch_secure() to reduce its verbosity.
By "verbosity", dym lines of code?
Jan
|
