[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()



On 12/04/2023 19:51, David Woodhouse wrote:
From: David Woodhouse <dwmw@xxxxxxxxxxxx>

Coverity spotted a double-free (CID 1508254); we g_string_free(path) and
then for some reason immediately call free(path) too.

We should just use g_autoptr() for it anyway, which simplifies the code
a bit.

Fixes: 7a8a749da7d3 ("hw/xen: Move xenstore_store_pv_console_info to 
xen_console.c")
Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
---
  hw/char/xen_console.c | 13 +++----------
  1 file changed, 3 insertions(+), 10 deletions(-)


Reviewed-by: Paul Durrant <paul@xxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.