[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/vcpu: ignore VCPU_SSHOTTMR_future
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 19 Apr 2023 16:02:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5t8N/uqflNeiN+ynmSj7yMfbYyfzQzjkJvfO6pvU/os=; b=kjMtIGOS8s+XNd9NNkFjDYprwcbqIe/Eg2w+t8tghL9rq541kXQ42SZ4VV8E9BTToTuTUYgJCuStcRkzXvscFoIFvV2sfpDvWrmQpALaO3+c4RUIJucgC5Mw68mjMcsq5HbJglhJ7A/xbMUvCbqbDJra3oZfz291/P5AyteMo2CdRMxgqcBKBRTcPM01eGoFVb464MJSxbiVSUl3nMSLyBoPxuHFdvKjq2+/p6SlU18B36WHKxgXFVZ7jEqaKwYSYIFRgtxFQhrUpiTM4fcsgjyxXwRomKZyfWIW4VEQm+E3lIZZYtC3CknhGM42Z1T48jOGZDWNeD5j60hIErKOlQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhOfWiZ/3HtBYYoDpahJtM8x2WbssuwxV925G9gt4Se+D64+GISNk1rj3Ut9sf/F8Bu9dpZs2BveMdnRrTNs7RKJdiyCZjP5vvBy8JEDHtLIE3bUtKbfoBZqldDBa8+BIFCE8CaXicQZjXAD10243piYc/6n1c5Bf3CX9nqL3Czr7yzB6Bre08xOwr7JLkpZuoIvuy7mmtwtPkC24Cm8fr05pktklM52kcsMebtOM293Pjrbm4+j45MlKVeE5MhqBC2z38dB/9lZgmHGuSyGzlhhgziKwoCFIiV+dmM0wfogQRcmMV1kTqQj3tDYNuOaJZx5knpIhjKia+eAvdG9bQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Henry Wang <Henry.Wang@xxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 19 Apr 2023 14:02:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.04.2023 15:22, Roger Pau Monné wrote:
> On Wed, Apr 19, 2023 at 02:14:44PM +0200, Jan Beulich wrote:
>> On 19.04.2023 13:45, Roger Pau Monne wrote:
>>> --- a/xen/include/public/vcpu.h
>>> +++ b/xen/include/public/vcpu.h
>>> @@ -150,7 +150,7 @@ typedef struct vcpu_set_singleshot_timer
>>> vcpu_set_singleshot_timer_t;
>>> DEFINE_XEN_GUEST_HANDLE(vcpu_set_singleshot_timer_t);
>>>
>>> /* Flags to VCPUOP_set_singleshot_timer. */
>>> - /* Require the timeout to be in the future (return -ETIME if it's
>>> passed). */
>>> + /* Ignored. */
>>
>> I think this could do with something like "as of Xen 4.18", as the public
>> header shouldn't be tied to a specific version (and then perhaps also
>> retaining the original text). Arguably mentioning a specific version may be
>> a little odd in case we'd consider backporting this, but something would
>> imo better be said.
>
> Hm, at least for XenServer we will backport this to 4.13, other
> vendors might backport to different versions, at which point I'm not
> sure the comment is very helpful. It can be misleading because it
> might seem to infer that checking the Xen version will tell you
> whether the flag is ignored or not.
>
> What about:
>
> /*
> * Request the timeout to be in the future (return -ETIME if it's passed)
> * but can be ignored by the hypervisor.
> */
Would be fine with me.
Jan
|
