[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v5 02/10] xen/arm: Typecast the DT values into paddr_t
- To: Michal Orzel <michal.orzel@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Wed, 19 Apr 2023 16:12:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PjStGSEMB1ILhnUhnahiOGJY3M/slAJ3k+sqICye4Ls=; b=FNYs01OPbfGrSeRn5miJjObZYcjQENrFCZoVWJqTPtAfRsDPt8i8USpr0+wglqYSnYc9XumjKSIXEiVa/mxvGzXM/dt+IcADjFkQglIEg7/6sWCHJAfs27hputZpmw+cTUwcPYXt66zVG7PrPq28Ecr1Qqf2Z9/pUYYfA+u2eS6y12EWfT8WO1uxTcZ4uZtC+/7EmWCz73ZV0JSmYJBcKBjUgjPU3HNCRmdeRYJ1ZEfkQl3jCGE+OcCaFUEDiMtbaR6yDZh7xq9o8UtHBO/De27608LMV022QvAziHze4BneJxvdtoImAW0MhWYWNmVtCMgQuf0aQ6xLAee9rGwy9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJewN83j+zcTt4VUNz8J99K6+L4/JQMw4u6rwMvk47gRLJtAdIV9PAqpX2FyzY59B2V2EPNx9byBDfG89K3weIwqzzrmbdJYCVCiTaHUMobjzCk+WB1xJamq+IJzbyjmcWjWOLNl8IFi71BasTdv75gshw/ZFBOPqxXpW1O5r4AlyXLXAz4o8OSdA7krfYJ2lbqMueMXYrIyC6G8NXG1aNKTlSW7FhwyZ8KvUdi4V5UB0D3e7gAcNVUbYvNSjhNwThMgpwO9mKB2QXxSf7M4ctj4hYy2qzuMxV4eecSRWyV/NsCIp52pf4PCGHHFewvefDieJ7eSKQjq8Hk0DRWjGQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: sstabellini@xxxxxxxxxx, stefano.stabellini@xxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, jbeulich@xxxxxxxx, wl@xxxxxxx, rahul.singh@xxxxxxx
- Delivery-date: Wed, 19 Apr 2023 15:13:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/04/2023 14:19, Michal Orzel wrote:
Hi Ayan,
Hi Michal,
...
--- /dev/null
+++ b/xen/include/xen/libfdt/libfdt-xen.h
@@ -0,0 +1,55 @@
+/*
+ * SPDX-License-Identifier: GPL-2.0-only
Our CODING_STYLE says:
New files should start with a single-line SPDX comment, ..., e.g.
/* SPDX-License-Identifier: GPL-2.0 */
For me it would be perfectly fine to do as you did but it is not what our docs
state
(i.e. single-line comment). It might be that we need to modify CODING_STYLE
instead.
Just to be clear, this is what we should have (as Julien had earlier
suggested to use **GPL-2.0-only** )
diff --git a/xen/include/xen/libfdt/libfdt-xen.h
b/xen/include/xen/libfdt/libfdt-xen.h
index 3296a368a6..cad7ad3bfb 100644
--- a/xen/include/xen/libfdt/libfdt-xen.h
+++ b/xen/include/xen/libfdt/libfdt-xen.h
@@ -1,6 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0-only
/*
- * SPDX-License-Identifier: GPL-2.0-only
- *
* xen/include/xen/libfdt/libfdt-xen.h
*
* Wrapper functions for device tree. This helps to convert dt values
- Ayan
|
