Re: [PATCH v3 02/17] xen/arm: implement helpers to get and update NUMA status

[Jan Beulich <jbeulich@xxxxxxxx>]

On 20.04.2023 13:25, Henry Wang wrote:
> From: Wei Chen <wei.chen@xxxxxxx>
> 
> NUMA has one global and one implementation specific switches. For
> ACPI NUMA implementation, Xen has acpi_numa, so we introduce
> device_tree_numa for device tree NUMA implementation. And use
> enumerations to indicate init, off and on status.
> 
> arch_numa_disabled will get device_tree_numa status, but for
> arch_numa_setup we have not provided boot arguments to setup
> device_tree_numa. So we just return -EINVAL in this patch.
> 
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> ---
> v2 -> v3:
> 1. Rename the first entry of enum dt_numa_status as DT_NUMA_DEFAULT.
> 2. Make enum dt_numa_status device_tree_numa as __ro_after_init and
>    assign it explicitly to DT_NUMA_DEFAULT.
> 3. Update the year in copyright to 2023.
> 4. Don't move the x86 numa_disabled() and make Arm's numa_disabled()
>    a static inline function for !CONFIG_NUMA.
> v1 -> v2:
> 1. Use arch_numa_disabled to replace numa_enable_with_firmware.
> 2. Introduce enumerations for device tree numa status.
> 3. Use common numa_disabled, drop Arm version numa_disabled.
> 4. Introduce arch_numa_setup for Arm.
> 5. Rename bad_srat to numa_bad.
> 6. Add numa_enable_with_firmware helper.
> 7. Add numa_disabled helper.
> 8. Refine commit message.
> ---
>  xen/arch/arm/include/asm/numa.h | 17 +++++++++++
>  xen/arch/arm/numa.c             | 50 +++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 xen/arch/arm/numa.c

While I was Cc-ed on this one, neither the diffstat nor any possible remarks
make clear whether anything is expected of me here.

Jan