[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [libvirt test] 180328: regressions - trouble: blocked/broken/fail/pass
flight 180328 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180328/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf <job status> broken build-armhf 2 hosts-allocate broken REGR. vs. 180308 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 180308 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 180308 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass version targeted for testing: libvirt 0d0604a51a5674e432335d201418cbba80899b73 baseline version: libvirt b486430db34d0db1dcbf39b0d9840d03cd57f615 Last test of basis 180308 2023-04-19 04:18:48 Z 1 days Testing same since 180328 2023-04-20 04:18:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik <mprivozn@xxxxxxxxxx> Pavel Borecki <pavel.borecki@xxxxxxxxx> jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf hosts-allocate Not pushing. ------------------------------------------------------------ commit 0d0604a51a5674e432335d201418cbba80899b73 Author: Michal Privoznik <mprivozn@xxxxxxxxxx> Date: Mon Apr 17 10:10:15 2023 +0200 networkRefreshDhcpDaemon: Get dnsmasq's PID once This is a relic of commit v3.7.0-rc1~132 when getter/setter APIs for dnsmasq's PID were introduced. Previously, obj->dnsmasqPid was accessed directly. But the aforementioned commit introduced two calls to virNetworkObjGetDnsmasqPid() even though the result of the first call is stored in a variable. Remove the second call as it's unnecessary. Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> commit 004d5141c59b08904396d53efe64ebe15f30c7b6 Author: Michal Privoznik <mprivozn@xxxxxxxxxx> Date: Mon Apr 17 10:10:04 2023 +0200 conf: Initialize _virNetworkObj::dnsmasqPid to -1 in virNetworkObjNew() Throughout all of our network driver code we assume that dnsmasqPid of value -1 means the network has no dnsmasq process running. There are plenty of calls to: virNetworkObjSetDnsmasqPid(obj, -1); or: pid_t dnsmasqPid = virNetworkObjGetDnsmasqPid(obj); if (dnsmasqPid > 0) ...; Now, a virNetworkObj is created via virNetworkObjNew() which might as well set this de-facto default value. Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> commit 212dfa94eeec88eb1a0bcf0c935a0ce17984306a Author: Michal Privoznik <mprivozn@xxxxxxxxxx> Date: Mon Apr 17 10:09:51 2023 +0200 networkUpdateState: do not assume dnsmasq_caps Assume there's a dnsmasq running (because there's an active virtual network that spawned it). Now, shut down the daemon, remove the dnsmasq binary and start the daemon again. At this point, networkUpdateState() is called, but dnsmasq_caps is NULL (because networkStateInitialize() called earlier failed to set them, rightfully though). Now, the networkUpdateState() tries to read the dnsmasq's PID file using virPidFileReadIfAlive() which takes a path to the corresponding binary as one of its arguments. To provide that path, dnsmasqCapsGetBinaryPath() is called, but since dnsmasq_caps is NULL, it dereferences it and thus causes a crash. It's true that virPidFileReadIfAlive() can deal with a removed binary (well virPidFileReadPathIfAlive() which it calls can), but iff the binary path is provided in its absolute form. Otherwise, virFileResolveAllLinks() fails to canonicalize the path (expected, the path doesn't exist anyway). Therefore, reading dnsmasq's PID file didn't work before v8.1.0-rc1~401 which introduced this crash. It was always set to -1. But passing NULL as binary path instead, makes virPidFileReadIfAlive() return early, right after the PID file is read and it's confirmed the PID exists. Yes, this may yield wrong results, as the PID might be of a completely different binary. But this problem is preexistent and until we start locking PID files, there's nothing we can do about it. IOW, it would require rework of dnsmasq PID file handling. Fixes: 4b68c982e283471575bacbf87302495864da46fe Resolves: https://gitlab.com/libvirt/libvirt/-/issues/456 Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> commit 03094f8c65f71b8cc55b73d1c2af575b0e84a23d Author: Pavel Borecki <pavel.borecki@xxxxxxxxx> Date: Wed Apr 19 07:48:48 2023 +0200 Translated using Weblate (Czech) Currently translated at 97.9% (10191 of 10400 strings) Translation: libvirt/libvirt Translate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/cs/ Translated using Weblate (Czech) Currently translated at 97.9% (10189 of 10400 strings) Translation: libvirt/libvirt Translate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/cs/ Co-authored-by: Pavel Borecki <pavel.borecki@xxxxxxxxx> Signed-off-by: Pavel Borecki <pavel.borecki@xxxxxxxxx>
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |