[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 24 Apr 2023 11:02:12 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hCuXoG30wTYkeE6MqC1JmC1YalYftOOrnEMgM01rwBw=; b=BYn0p+/rpsXylCgPLZM3vpyGeyOYJfTnF+so+rWh2vQWGSo+/Ns9daPrtlF5vNAdnoPt3EyqJ9VMMJLL8nolJdzv0qiSbcEzzHg3+3GZDPWUrnfRgiFBR/e4Q1SzNcLFOI8cQ2+w5WV+t91EfmrfN0dt4aK3UfWaudn8FVncFLG33I5KGhhNztaGdkG7fN1u1ku1x4+XI/xPDNMsKJ7VZawXtevuShYNWjtmRFvLWBhLphdIceqwZNjUSjbDK8SPLpp1QdfwRk3DDA7vgcjWorlsXEnOBPLcniLgf937N6VUvZf04Tj9iAgKiSS1OtZDSVSAr+CZO/PQkLHsD9Pt9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfk5zpn3YJA1tZR3+tZmjNqgfz/SurNmhEhjU+Ye2QYRyZ/qk+IQTR139xRVIrwas7jzAkLtmoZG4IBh0sM+NQyHXRNo05MmyBs5Qp0KrH0vZ6Ryxv+drBJk8/1tvaNDrrd8n9EKBjcGLgdTRUEdmk2m1g87q+4bO92FyJV/60/tK+gJjsMBI3pHkSJlixkPFkbdrbabfeslK5nUjcq8CUKCVaWn+ItzMG9sqfrM2xlnqqvITCAaKQAFAQ5y+WBoz2LuKHXbb9ktD7+6kWo/7BPTYhv4NChi0qjHirkG0OXIHq0eveNYnrFsaii2JgdbqIkTyoaLX75Anrxf1HSubg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 24 Apr 2023 11:02:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZc3rmCrt50C+BaEmmIgaK9uo9ea80IxGAgAFPzpCAABDqgIAC3lpQgAG3XoCAADcqoA==
- Thread-topic: [PATCH v3 03/17] xen/arm: implement node distance helpers for Arm
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: Re: [PATCH v3 03/17] xen/arm: implement node distance helpers for
> Arm
>
> On 23.04.2023 07:36, Henry Wang wrote:
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >>>> However, looking at the code below, don't you mean to have the array
> >>>> pre-set to all NUMA_NO_DISTANCE?
> >>>
> >>> ...I am a bit puzzled about why pre-setting the array to all
> >>> NUMA_NO_DISTANCE matters here, as I think the node distance map will
> >>> be populated when parsing the device tree anyway no matter what their
> >>> initial values.
> >>
> >> From this patch alone it doesn't become clear whether indeed all array
> >> slots (and not just ones for valid nodes) would be populated. I think
> >> the code in the patch here would better not make itself dependent on
> >> behavior of code added subsequently (which may change; recall that a
> >> series may be committed in pieces).
> >
> > Correct, I agree. I added a numa_init_distance() function (in patch #12) to
> > set all values to NUMA_NO_DISTANCE. The numa_init_distance() will be
> > called in the beginning of numa_init().
>
> Why do you need a function for this? As said, this array can be pre-set at
> compile time (unless I'm overlooking something).
Sorry I overlooked this comment, correct me if I am wrong, but IIUC we
can only pre-set the 2D array to 0 at the compile time. Could you please
elaborate a bit more about the code in your mind? Thanks!
Kind regards,
Henry
|
