Re: [PATCH v2] xen: add support for crash dump analysis with xen.efi

[Juergen Gross <jgross@xxxxxxxx>]

On 24.04.23 16:50, Jan Beulich wrote:
> On 24.04.2023 16:30, Juergen Gross wrote:
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -226,6 +226,9 @@ endif
> >               $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) 
> > $(note_file_option) -o $@
> >         $(NM) -pa --format=sysv $(@D)/$(@F) \
> >                 | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort 
> > >$(@D)/$(@F).map
> > +ifeq ($(CONFIG_DEBUG_INFO),y)
> > +       $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:,$(OBJCOPY) -O 
> > elf64-x86-64 $@ $@.elf)
> This only addresses one of the two earlier raised aspects, as you didn't
> use what I proposed:
>
>         $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:)$(OBJCOPY) -O 
> elf64-x86-64 $@ $@.elf
>
> Quite possibly because there was a blank missing in there, to separate
> the colon from $(OBJCOPY). Preferably with the adjustment (which I'd
> be fine doing while committing, as long as you're okay)
Took some time to understand your concern here, but finally I've got it. :-)

Yes, I'm fine with this change.

> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.

> To also mention what we have just discussed: Since we're talking about
> duplicating over 30Mb of data (at least according to my build), an
> option is going to be to then strip debug info off of xen.efi itself,
> getting its size into reasonable range again.
Yes, this would shrink it to a little bit above 3MB.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature