[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/6] automation: include tail of serial log in the gitlab outout



On Mon, 24 Apr 2023, Marek Marczykowski-Górecki wrote:
> Make it a bit easier to see what has failed.
> 
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  automation/scripts/qubes-x86-64.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/automation/scripts/qubes-x86-64.sh 
> b/automation/scripts/qubes-x86-64.sh
> index 6442f7dda515..9b89d90f653c 100755
> --- a/automation/scripts/qubes-x86-64.sh
> +++ b/automation/scripts/qubes-x86-64.sh
> @@ -228,5 +228,6 @@ fi
>  
>  sleep 1
>  
> +tail -n 100 smoke.serial
>  (grep -q "^Welcome to Alpine Linux" smoke.serial && grep -q "${passed}" 
> smoke.serial) || exit 1
>  exit 0

Isn't smoke.serial already in stdout and also part of the artifacts? The
user can always click on the full output or on the smoke.serial file
among artifacts.  Maybe the issue is that it is called ".serial" instead
of ".txt" so the browser will not try to open it directly in a browser
window. If we rename it to ".txt" the user could just click on
"artifacts" and then on "serial.txt" and it would be all there.

100 lines is not much, but I think in general it is better if we make it
easier to access smoke.serial in its entirety instead.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.