[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix install.sh for systemd


  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 26 Apr 2023 11:07:17 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GkSjVz2yZSYybsLyLMUVxLzZYRjqtAbROe0L+OSR2XU=; b=PivZAujCuWwQGytxovwcHSaaS8kvnUTu13Y/bUWDuaqVVQwGQFk2OoqHKu8/Rxop09vKnOTs0w4gQe7pm7PVKiwyG8nV8SGRZSfpE+Is2vDvwqVVJlazBayo34WSv/JHaQUnX8qg06pqj/OMFIlm+RQ4wBGrcQ25jhOLFpLfudQSXu6B8uhjmWdolvpt0XBFdI/O/pA0XwV4EudrlNN70GQ0lu/IxDUiawBzZJatGdog0yBH0VOeD/uq+01/Zd5mn82uh+Zr+waXLJf8pU9ux/24yFaR15Iq/U3EWZfKu1nYZHtRZtx+flo4tOseitaXu2E62QTSUq9F2ivR6xwugw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n93/cOZQKl4v6rkZfsPsNQmTkqAcPdxnFBtOEYfVk9dQO1QtHdMa8bSM4yFoiKMizkL1lDvm/G1n1T7pMR8xHw0Dj+iJFBYBhDDjoAFb+Hsk4+iu/0QcSW/MYoVdokjXd25rqSKefTsF5gpqQBPQfN0/PBO7dVeMuEHKfcRW2OfeyS5UFxdsL/MS5zl8KJ/YTRKaaDqyCJs4TDvJVko+9nOyP1ADseweDrke6E76o3nC5sAdKMIrJJqshmE9JxQ8/r3Qe4e4zpot9fF11E4VJMR4Bslct7rhmdjTb2H0zxQ6tdsBr0280+dbF0vHQd1XKTzgcKLvGoWVW02ICdSeHw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
  • Delivery-date: Wed, 26 Apr 2023 09:07:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.04.2023 10:47, Olaf Hering wrote:
> Wed, 26 Apr 2023 10:28:38 +0200 Jan Beulich <jbeulich@xxxxxxxx>:
> 
>> Is this to be translated to Reviewed-by: <you>?
> 
> It was a Nack, in case such thing exists, and if it has any meaning if sent 
> by me.

Now I'm confused: Your reply didn't read like a nack at all, at least to
me. Furthermore ...

> There are a few places already which do a mkdir -p XEN_RUN_DIR prior usage.
> But a few are missing.
> XEN_RUN_DIR and most likely also XEN_RUN_STORED have to be removed from make 
> install.

... this suggests to me that you really mean the change doesn't go far
enough, but that's then different from nack-ing a change. Can you please
clarify this for me (and maybe also for Jason, depending on how he has
read your replies)?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.