[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v1] stubdom: fix errors in newlib:makedoc


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Wed, 26 Apr 2023 10:52:39 +0000
  • Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1682506362; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=FGgNeMXD1fpexIJRy+L7hZ4dIGHGd8+SytNB0T7EbIo=; b=D6/CsQ4f0aYGmnI0YT7CETI+l2HWhROAw1BLQt0yUFC8egLStQawlDenTYK993ucbo 7+VM0xSi43KAo1JzEWGNNeA4rP7HSmR1zn+TM9gU73Y5g+jHgBWfk3cGUsQyXsvtN07T i1gAboA4ww9SROyDQU44MGoNcqhI3JCR98FWxLZ6uiKcg/Y58x+zTeffjtpFdiUI1ZAH QK3iyo6Xi21+hjKmVsg/V1TDrePyoxJgnQ1Xz4e6joMYbi4R0w74r6XXLi5oqORElRfn ZtgYwUkMJoFut1ainqGyN+Hs4o6QlzX3O6VqH5RA8goyXGn+G2riBItZCKCrnWKpGkEL Ko/g==
  • Arc-seal: i=1; a=rsa-sha256; t=1682506362; cv=none; d=strato.com; s=strato-dkim-0002; b=fDSnyS0AnPUWEsBPNKZT8Fza6aye84168oMlcIM8ES38acohynGIhJgSIczWo1zrpX hZYCwtxQqZF0pZpG2VAyy309HMj8OKY/TB+AvaRv8w7P15DLVmTaYVnf7Mk2ADLtmXOd hzO5T1JklfEO1XZR/VNAN6qj3Ln/qiSqbNgz2vcqfHa2DBBxOlwrgNdDk0yWXFYcd5vx 26GI4PqpSgYOxp2dtbyqUaFb4OuMwxei52tb4EJmC7vokJc7avT2erKcXLkipq/TAigz pKZcSxW9arADq6ypCZVbavWamAQC5R6Xxc6De8+em4vS4g8TUpG06z2mBZo1vGLl9fAW LLEw==
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
  • Delivery-date: Wed, 26 Apr 2023 10:52:49 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

rpm post-build-checks found a few code bugs in newlib, and marks them as
errors. Add another newlib patch and apply it during stubdom build.

[  227s] ../../../../newlib-1.16.0/newlib/doc/makedoc.c: In function 
'lookup_word':
[  227s] ../../../../newlib-1.16.0/newlib/doc/makedoc.c:1147:10: warning: 
implicit declaration of function 'strcmp' [-Wimplicit-function-declaration]
[  227s]       if (strcmp(ptr->word, word) == 0) return ptr;
[  227s]           ^

[  460s] I: Program is using implicit definitions of special functions.
[  460s]    these functions need to use their correct prototypes to allow
[  460s]    the lightweight buffer overflow checking to work.
[  460s]      - Implicit memory/string functions need #include <string.h>.
[  460s]      - Implicit *printf functions need #include <stdio.h>.
[  460s]      - Implicit *printf functions need #include <stdio.h>.
[  460s]      - Implicit *read* functions need #include <unistd.h>.
[  460s]      - Implicit *recv* functions need #include <sys/socket.h>.
[  460s] E: xen implicit-fortify-decl 
../../../../newlib-1.16.0/newlib/doc/makedoc.c:1147

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
---

Depends on newlib-cygmon-gmon.patch

 stubdom/Makefile             |  1 +
 stubdom/newlib-makedoc.patch | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+)
 create mode 100644 stubdom/newlib-makedoc.patch

diff --git a/stubdom/Makefile b/stubdom/Makefile
index cddbbe2da0..a21e1c3fa3 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -96,6 +96,7 @@ newlib-$(NEWLIB_VERSION): newlib-$(NEWLIB_VERSION).tar.gz
        patch -d $@ -p1 < newlib-stdint-size_max-fix-from-1.17.0.patch
        patch -d $@ -p1 < newlib-disable-texinfo.patch
        patch -d $@ -p1 < newlib-cygmon-gmon.patch
+       patch -d $@ -p1 < newlib-makedoc.patch
        find $@ -type f | xargs perl -i.bak \
                -pe 's/\b_(tzname|daylight|timezone)\b/$$1/g'
        touch $@
diff --git a/stubdom/newlib-makedoc.patch b/stubdom/newlib-makedoc.patch
new file mode 100644
index 0000000000..90678f1b63
--- /dev/null
+++ b/stubdom/newlib-makedoc.patch
@@ -0,0 +1,35 @@
+stubdom: fix errors in newlib
+
+rpm post-build-checks found a few code bugs in newlib, and marks them as
+errors. Add another newlib patch and apply it during stubdom build.
+
+[  227s] ../../../../newlib-1.16.0/newlib/doc/makedoc.c: In function 
'lookup_word':
+[  227s] ../../../../newlib-1.16.0/newlib/doc/makedoc.c:1147:10: warning: 
implicit declaration of function 'strcmp' [-Wimplicit-function-declaration]
+[  227s]       if (strcmp(ptr->word, word) == 0) return ptr;
+[  227s]           ^
+
+[  460s] I: Program is using implicit definitions of special functions.
+[  460s]    these functions need to use their correct prototypes to allow
+[  460s]    the lightweight buffer overflow checking to work.
+[  460s]      - Implicit memory/string functions need #include <string.h>.
+[  460s]      - Implicit *printf functions need #include <stdio.h>.
+[  460s]      - Implicit *printf functions need #include <stdio.h>.
+[  460s]      - Implicit *read* functions need #include <unistd.h>.
+[  460s]      - Implicit *recv* functions need #include <sys/socket.h>.
+[  460s] E: xen implicit-fortify-decl 
../../../../newlib-1.16.0/newlib/doc/makedoc.c:1147
+---
+ newlib/doc/makedoc.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+Index: newlib-1.16.0/newlib/doc/makedoc.c
+===================================================================
+--- newlib-1.16.0.orig/newlib/doc/makedoc.c
++++ newlib-1.16.0/newlib/doc/makedoc.c
+@@ -38,6 +38,7 @@ There is  no
+ #include "ansidecl.h"
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <string.h>
+ #include <ctype.h>
+ 
+ #define DEF_SIZE 5000



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.