[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/misra: xen-analysis.py: fix return error on PhaseExceptions
- To: Luca Fancellu <luca.fancellu@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 26 Apr 2023 15:08:53 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FIsfvn7vHUmyaygHz/bYx2AUse3OvQ/Ew7Xno2+dzY8=; b=N60K+fIB10EDB7L+0Aarl8oar6eR8NwdY2xvt6SHhbdfbG3IvdOa+uTLSUijAGoUASZYTdyf2DmhE1UD7JW4T0hHj06jh4FAnqsxzMoA6tYpKLTM8Lz3LP3VWmkMs2esKgyfGtsFryj3I6BW4CuTmOl+x+J1AgqN6Y8GbA2lXtrw6B4CcPWAIlXGtBB1QXfwqlOA6ET8HoWhTzWEcixGSsKeBsFPuwoHM560yJFzvTWNH/nnmZO1Q0YAyRQF0Y6Ym1vr7loQjTU5UW7gPL4j3mHBTVbRR/jO/iNI1WTUkaE+gsr8bMso17HuxClNjbfW03CapvjtJ+7QzSO9dX8zXg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oK7lXgUcsQd07IcfYgaT/Ko0BFYGGY8sG3LqlgwGgnlGucpznaVaRPlT5HsG6bDdWmvx5qMwlZ9DhePo+0Ct90F1ZMQrG4NjOqvApaf9RvaoE2Tfm3JVYhoI3+RYPOZf4jrx0zfl6zYlKB6mfh3XM5gALcDwSeiMVLQoHhOI32vpeaXdJUFKEe8XxLq+r1VJ166KUt59EehRxtgS45X+ZFFiBGyZ6dNmRGe4hbHf6tF+zI2fTZzcHMBPE+H28XzTLbhsN4tSYDinLLgfR8ctM9iZYj7amaN8SPVIloSgn5SDCIAmmsv4qWG0/SHuEkqKghYyLEv3avauoX1G5ceytQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 26 Apr 2023 14:09:22 +0000
- Ironport-data: A9a23:za65DqzsB/rQ9yPby1F6t+ehxyrEfRIJ4+MujC+fZmUNrF6WrkUDy WJLWG6BM6uMNjH2c99xa9/k9U1U6JLUyIdmSgZupCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRiP64T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU5Vy s0XLyBdUhmko6WN5a2UV/NC3+12eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQtuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiANxCTu3gqKYCbFu7xU4wUSYIUWuBneSBuHaFa5FWF lEU0397xUQ13AnxJjXnZDW8vXWN+BAVXdFdF+knwAiXz+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8pz6oJTIcK2NEYCYeVBYE+PHquoR1hRXKJv58Ha/zhd34Hxn52 TXMpy87750Rh8MW06Sw/Xjcnimh4JPOS2Yd5BjTX2+jxhN0YsiifYPAwUPA8f9KIYKdT1+Al HsJgc6T6KYJF57lvDOJaPUAGveu/fntDdHHqVtmHp1k/TLy/XemJNhU+GsnfBsvNdsYczj0Z kOVoRlW+JJYIHqta+lwfp61DMMpi6PnELwJS8zpUzaHWbApHCfvwc2kTRf4M7zF+KT0rZwCB A==
- Ironport-hdrordr: A9a23:UNjsjqwpmFdQMfXspgg5KrPwAr1zdoMgy1knxilNoERuA6ulf8 DHppsmPGzP+VAssRAb6Kq90ca7MBDhHPJOjLX5eI3SODUO21HYUb2Kj7GSoQEIcheWnoU26U 4jSdkaNDSaNzZHZLPBgDVQZOxA/DDoysyVbKzlvg5QpElRGtldBilCe32mLnE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26/04/2023 11:46 am, Luca Fancellu wrote:
> Currently the script return code is 0 even if an exception is
> found, because the return code is written only if the exception
> object has the errorcode member.
>
> Fix the issue returning the errorcode member in case it exists,
> otherwise use a generic value different from 0.
>
> Fixes: 02b26c02c7c4 ("xen/scripts: add cppcheck tool to the xen-analysis.py
> script")
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> xen/scripts/xen-analysis.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/xen/scripts/xen-analysis.py b/xen/scripts/xen-analysis.py
> index 8e50c27cd898..7185c5a06d2c 100755
> --- a/xen/scripts/xen-analysis.py
> +++ b/xen/scripts/xen-analysis.py
> @@ -26,8 +26,7 @@ def main(argv):
> cppcheck_analysis.generate_cppcheck_report()
> except PhaseExceptions as e:
> print("ERROR: {}".format(e))
> - if hasattr(e, "errorcode"):
> - ret_code = e.errorcode
> + ret_code = e.errorcode if hasattr(e, "errorcode") else 1
ret_code = getattr(e, "errorcode", 1)
is rather more succinct, and pythonic.
~Andrew
|
