[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] CI: Remove all use of /bin/false as a ROM
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 26 Apr 2023 15:47:48 +0100
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 26 Apr 2023 14:48:20 +0000
- Ironport-data: A9a23:Pu0twqlf8HIzQI0x986d+pvo5gy5JkRdPkR7XQ2eYbSJt1+Wr1Gzt xJKUTqHaaqJNGP9KYonatnl908FsZeDxt9hTwY4qS43RCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aWaVA8w5ARkPqgX5gGGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 ftCMhQTZTKkvcan5uupVvZKou8bEPC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQth/A+ TmbpjSnX3n2MvTDzR+qyFeG2tT0siejALwRJua88vVT1Qj7Kms7V0RNCArTTeOCoku/UNJWL woT4DgjqYA78UDtRd74NzWzqWSIuRM0UNNKH+o3rgqKz8L85g+DA2EeQz1pado4tdQ3Tzgny l+ImdzyATVl9raSTBq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kbnh/JC9puDqOxptn0Ai3rh SCHqjAkgLcehtJN0L+0lW0rmBr1+MKPFFRsoFyKACT8tFgRiJOZi5KA7gLByehLDqGjakin5 WoYhO66x9gyNMTY/MCSe9nhDI1F9t7cbm2G2g8yR8Rxn9i+0yX9JN4NuVmSMG8sa59ZImGxP Sc/rCsLvPdu0G2Wgbibim5bI+Aj1uDeGNvsTZg4hfIeM8EqJGdrEMyDDHN8PlwBc2B2y8nTw b/BLa6R4Y8yUMyLNgaeSeYHyqMMzSsj327VTp2T5035geDCOCHLFulUYADmggUFAESs+V29z jqiH5HSl0U3vBPWOUE7DrL/3XhVdCNmVPgaWuRcd/KZIxoOJVzN/8T5mOt7E6Q8xvQ9qws91 i3lMqOu4Aal1CKvxMTjQiwLVY4Dqr4l/CtkYHF8YA32s5XhCK72hJoim1IMVeFP3IReITRcF JHpp+3o7ixzdwn6
- Ironport-hdrordr: A9a23:3bjfQqCGylXXJ6rlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
As the recent work to get PCI Passthrough testing working shows, putting
`/bin/false` as a ROM into guest context doesn't work so well.
For all ROM paths where we're skipping the build, use a slightly-plausible but
likely non-existent path instead.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Michal Orzel <michal.orzel@xxxxxxx>
CC: Doug Goldstein <cardoe@xxxxxxxxxx>
CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
---
automation/scripts/build | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/automation/scripts/build b/automation/scripts/build
index d830cff7b7c7..197d085f3e07 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -67,9 +67,9 @@ else
if [[ "${cc_is_clang}" == "y" ]]; then
# SeaBIOS cannot be built with clang
- cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
+ cfgargs+=("--with-system-seabios=/usr/share/no-seabios.bin")
# iPXE cannot be built with clang
- cfgargs+=("--with-system-ipxe=/usr/lib/ipxe/ipxe.pxe")
+ cfgargs+=("--with-system-ipxe=/usr/share/no-ipxe.pxe")
# newlib cannot be built with clang so we cannot build stubdoms
cfgargs+=("--disable-stubdom")
fi
@@ -87,7 +87,7 @@ else
# SeaBIOS requires GCC 4.6 or later
if [[ "${cc_is_gcc}" == "y" && "${cc_ver}" -lt 0x040600 ]]; then
- cfgargs+=("--with-system-seabios=/bin/false")
+ cfgargs+=("--with-system-seabios=/usr/share/no-seabios.bin")
fi
./configure "${cfgargs[@]}"
--
2.30.2
|
