Re: [PATCH 4/7] tools: Make init-xenstore-domain use xc_domain_getinfolist()

[Juergen Gross <jgross@xxxxxxxx>]

On 26.04.23 16:59, Alejandro Vallejo wrote:
> It currently relies on xc_domain_getinfo() returning the next available
> domain past "first_domid", which is a feature that will disappear in a
> future patch.
>
> Furthermore and while at it, make it so the hypercall tries to fetch information
> about more than one domain per hypercall so we can (hopefully) get away with a
> single hypercall in a typical system.
>
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> ---
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>
> ---
>   tools/helpers/init-xenstore-domain.c | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/tools/helpers/init-xenstore-domain.c 
> b/tools/helpers/init-xenstore-domain.c
> index 0950ba7dc5..5f40901d31 100644
> --- a/tools/helpers/init-xenstore-domain.c
> +++ b/tools/helpers/init-xenstore-domain.c
> @@ -21,6 +21,7 @@
>   #define LAPIC_BASE_ADDRESS  0xfee00000UL
>   #define MB(x)               ((uint64_t)x << 20)
>   #define GB(x)               ((uint64_t)x << 30)
> +#define ARRAY_SIZE(x)       (sizeof(x) / sizeof((x)[0]))
Please include <xen-tools/common-macros.h> instead of defining ARRAY_SIZE().

With that changed:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature