[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3 1/2] acpi: Make TPM version configurable.
Hi, Jennifer, On Tue, Apr 25, 2023 at 1:48 PM Jennifer Herbert <jennifer.herbert@xxxxxxxxxx> wrote: > > This patch makes the TPM version, for which the ACPI libary probes, > configurable. > If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should > be probed. > I have also added to hvmloader an option to allow setting this new config, > which can > be triggered by setting the platform/tpm_version xenstore key. > > Signed-off-by: Jennifer Herbert <jennifer.herbert@xxxxxxxxxx> ... > --- a/tools/libacpi/build.c > +++ b/tools/libacpi/build.c > @@ -409,38 +409,47 @@ static int construct_secondary_tables(struct acpi_ctxt > *ctxt, ... > + switch ( config->tpm_version ) > { > - tcpa->lasa = ctxt->mem_ops.v2p(ctxt, lasa); > - tcpa->laml = ACPI_2_0_TCPA_LAML_SIZE; > - memset(lasa, 0, tcpa->laml); > - set_checksum(tcpa, > - offsetof(struct acpi_header, checksum), > - tcpa->header.length); > + case 0: /* Assume legacy code wanted tpm 1.2 */ This shouldn't be reached, since tpm_version == 0 won't have ACPI_HAS_TPM set. Still, do you want to make it a break or drop the case to avoid falling through to the TPM1.2 code? Looks good though. Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx> Thanks, Jason
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |