[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] acpi: Add TPM2 interface definition.
- To: Jason Andryuk <jandryuk@xxxxxxxxx>
- From: Jennifer Herbert <jennifer.herbert@xxxxxxxxxx>
- Date: Thu, 27 Apr 2023 15:22:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DmGZ5QmJqK4pu+gOZzCUk686UjjFCwoRO4ZHGu4/hbY=; b=lrGEOpe8T9FiUn7OO8i3O7bRp7dvoK8jTQG/8S0qK1esidxh8tWhIp1ir1usbjj6Lu2RNMRWFI6Fd40YQdEo+93liuXTfjA7YiAnjXSItHRNrLOHNErITtGhpRj2zSuEkCZd+g188kO8pVKkSmraNVjs/5p/ua8qeumvizkfs1QRJZ+5fu+DJvKyyxxezrzfW0P7fR5/zbTh9+IyUPvepovUtfFwBDm38D1cmVc1ZGSD9b/InlkceSslsqJx5imvr/3mChwYwNpcADRln4oafZGJSVIshkkrGHeal1tH7Yp5D2oXzn6ajMhvtz+K0Ssd+8vLCgPopvTEtmARU5QRWg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJd/WEotfqua+iIaQVGXuX94IiZrFKhWaLJLrLl79HAWMqfaFdXS0UUCxwVE2UvSpjXdNYDlJDhsVrULqdNhHGl2vEsZCvEviBBWQE2MqXjiD+gKmJW1GBldfm46hsJ47UwIFBolDnJwjXfQll0cVCNSeWq4Y530uC67YROAV7xFvf6wbA1Axnlgi/Z2dNRpCfFAW7Grb9NpNhBPLgbp77765ZzDkhcDa9Ye+HlyUwsdPMdC0ox+lp7Uu9Mow+3B7byv5XcLTIsdYedOU3f3mIrNC5jUtf60eX+tZNP5W+FX4YOCixdWDNsRsb4F0OHPtBIjQLOfE83KeBSZbRLr3g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: jennifer.herbert@xxxxxxxxx, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 27 Apr 2023 14:23:05 +0000
- Ironport-data: A9a23:Oq4NjKAqkFuNAhVW/+Liw5YqxClBgxIJ4kV8jS/XYbTApG53gmAEn GEdCz/XPfzYZDTyctEjO4qz9kpVuZeDztdnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G9C4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5vY0OHF8+ fciJzEtM0vYi8mM54CmY7w57igjBJGD0II3nFhFlGmcKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuuzS7IA9ZidABNPLXd9qMRMtYhACYq 3jM8n7lKhobKMae2XyO9XfEaurnxHumCN9ISOzhnhJsqBqdmS88ChMRbGaAqPulkBS9fs9kN 0NBr0LCqoB3riRHVOLVXRS+rGSVox00VN9ZEul84waIooLW7gCfB2YJVHhBZcYsudUqbTcry kWZ2djuAFRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85jrNRNt+FK++jvXuBCr9h TuNqUADa647iMcK0+C+4grBijf1/pzRFFdtukPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytaVUwXXYH80EdygmQ
- Ironport-hdrordr: A9a23:mz1m0qh7w3c9UiuLJrl/S1501nBQXuEji2hC6mlwRA09TyX4rb HWoB1/73TJYVkqKRYdcLy7Scq9qArnlaKdgrNhW4tKPjOKhILAFugLh7cKpQeQeREWndQtsZ uIHZIObeEYOmIXsS8q2miF+4dJ+re6GP7Bv4jj80s=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26/04/2023 21:29, Jason Andryuk wrote:
On Tue, Apr 25, 2023 at 1:48 PM Jennifer Herbert
<jennifer.herbert@xxxxxxxxxx> wrote:
This patch introduces an optional TPM 2 interface definition to the ACPI table,
which is to be used as part of a vTPM 2 implementation.
Signed-off-by: Jennifer Herbert <jennifer.herbert@xxxxxxxxxx>
---
...
diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c
index f39a8e584f..51272530fe 100644
--- a/tools/firmware/hvmloader/util.c
+++ b/tools/firmware/hvmloader/util.c
@@ -1009,6 +1009,15 @@ void hvmloader_acpi_build_tables(struct acpi_config
*config,
config->table_flags |= ACPI_HAS_TPM;
config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS;
break;
+
+ case 2:
+ config->table_flags |= ACPI_HAS_TPM;
+ config->crb_id = (uint16_t *)TPM_CRB_INTF_ID;
+
+ mem_hole_populate_ram(TPM_LOG_AREA_ADDRESS >> PAGE_SHIFT,
+ TPM_LOG_SIZE >> PAGE_SHIFT);
+ memset((void *)TPM_LOG_AREA_ADDRESS, 0, TPM_LOG_SIZE);
TPM_LOG_AREA_ADDRESS is reserved in the e820 table since it is the
high memory range after the ACPI data, correct?
This is my understanding yes. We made sure to put it well clear of the
qemu impremnted TPM, just incase it later decided to support more
localitie levels, but still well within the RESERVED area, in the e820.
-jenny
Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
Thanks,
Jason
|
