[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/7] tools: Make init-xenstore-domain use xc_domain_getinfolist()


  • To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 28 Apr 2023 14:10:33 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0w+W2qlgNdJyfzB8ZjTgO8zdBPcBlG2cWo8OFLLGWQk=; b=PSPKQtoK44DlBAzL1I/XUy0a9u80I9fmXeV2fGe9dW5MBGTxxbRt7M+oeWS/pRI5htGeB4swHWWIYM3ByMf60kg78CN9/1M2YHshGB+fR68y+KzHPN9XmLOxqo2ajS9/Yv3Z17/9we7rGgvhSgVMSqIsM83zY/4CnXvmai+E7zCqDAmlRkjXJDswWPAn/S9LpUHDs39cOOw7Onfw4pCMfyE3nWMeYkMrRwRQ1kpwiZLp6hLyAbCTqphz543+VI1Og6K1aUexyKJwmnGBrMbTCCM5skxPYOU+7KBKSrF4/QoSboQxa44ESWYr7WD8q09bP8vj6AwahNgQ+xTxVRxZDQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A78sn13xEpzA1FmPOI4QMgR/2159fTfKC/MSSi1EwiOSkS4pPUq3cqAdRaoX46MhmqL1pIwRqKX466OrV0fIxYTXKpZoY4cBaQ78/U9A4qOi7kL4oZLbDaoBNGoz/qMq56N/h+XvEGEiGny91K8OOpCaCr3P18G52W5JGaIZM3xPAxW+BqrP38sBl7nNE99RS24W/GtM8uqHrAbVp5lO2PguxuTU7vZx++YddRS0/re+hvpRYYPIGEUsudCKKst8FJgPKx54ey9Nh2Fps+YuYM77u2XAAbFd5wMtJsmzP8x9fqllqd3k6dfXZUYVF9TF5zWNZQYxA1Q4S+Ez5bilWw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Fri, 28 Apr 2023 13:10:59 +0000
  • Ironport-data: A9a23:tt0fWq9bfiqzNPI5LjQGDrUDRn+TJUtcMsCJ2f8bNWPcYEJGY0x3z GFOUTqOafmLMzanft0gPN7joR8BupLQztJjHVA//ys8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOaob5AO2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklQ8 sIKcG0xNSqZvPjm7YDlU/k8uN4seZyD0IM34hmMzBn/JNN/GNXoZPyP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilUuiNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpMSeDgrK406LGV7ncaMToTUEm7m+u0mk6GZoJxB kZJqhN7+MDe82TuFLERRSaQqXqJvBcaV8BXVfMz7AWAyK386AKeG2RCRTlEAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BXAGTT8JS00C+daLiIM8lBXUVf54DbW4yNrvFlnNL yuiqSE/g/AYipcN3qDipFTf2Wvz/t7OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lRtlFO97t3OXgvGNS
  • Ironport-hdrordr: A9a23:teMJ6q8A57Dahorj0iFuk+DcI+orL9Y04lQ7vn2ZHyYlFvBw9v rPoB1173TJYVoqMk3I+urgBEDjexzhHMVOkOws1N6ZNWHbUQ2TQb2KhrGN/9SPIUHDHkE279 YGT0DTYueAbmSTLKzBkWuFL+o=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28/04/2023 11:41 am, Alejandro Vallejo wrote:
> It currently relies on xc_domain_getinfo() returning the next available
> domain past "first_domid", which is a feature that will disappear in a
> future patch.
>
> Furthermore and while at it, make it so the hypercall tries to fetch 
> information
> about more than one domain per hypercall so we can (hopefully) get away with a
> single hypercall in a typical system.
>
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> ---
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>

Oh, also, you should have retained the Reviewed-by: that Juergen gave
you on v1, seeing as you did precisely what he asked.

Same for my R-by on patch 7, except there's a different hiccup there now...

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.