[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/sysctl: fix XEN_SYSCTL_getdomaininfolist handling with XSM


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 2 May 2023 09:19:59 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ge+zmYmWwl76Lvy1vCFAkPgqQs+CeCMIZ3C1bhjNBu4=; b=kQRXUKz/nct7A/y1z5cxFiZWGXFm7XFGRfJtklbFb5F1nnM4GSreQD9KDrK2GZ6TR0UnayKKuoEbgJRrXmqnXJ4c8oxtX0GTYws02w/4kE13iCIq8V7wqSj3mcO7PKBmHz71rjmsG+UYuagJIrXZWqDBjXtfTu4hMe3U6dynPb2EO4SpfUobsvTNok4YVCuUdOf19LOm25oyG84B3pqM2BiONwYAj5G7WIMMcy97M03BTNw1vNaC97g3fpSvL1NiIcE5bTR17srrhiy5cqYyeSVIB/4YX8zK/DbLnncmphygUudjfAU8GTOVLA5eypTrVXQJZTIPWuEKV5B662iMaw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bIgnX4Su5oMzTFIjPaDeciXZi6yPfjLIv4l2JxSENMTrlEfskPrHELiL33m7WcJrRTsjWOvNziMn5cDyef+t18cMm0koQ1m1nC2pJjvkemwidO5NuDAydqSGcV4V8WacEzXk3Ni8HMm4CzyJdICm2mpu+RWTT2O6xOT9KU/lm2onRFmALcixsT5Gwq//Jvto+Naey69aT5F3+hHj2jPjiALYoiyvwXEmlCnu7LjOGIF4HBUKA0xTDVJoJN/sa5ftE27lkCkwH/ApJRdT9WTT4rP8xqrTXQnSiER1CK1bYRXNzlvEdqbrzQEVLok4AIvYtirwzizpwf1Z/5JfYbV+2Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 02 May 2023 07:20:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30.04.2023 16:46, Juergen Gross wrote:
> In case XSM is active, the handling of XEN_SYSCTL_getdomaininfolist
> can fail if the last domain scanned isn't allowed to be accessed by
> the calling domain (i.e. xsm_getdomaininfo(XSM_HOOK, d) is failing).
> 
> Fix that by just ignoring scanned domains where xsm_getdomaininfo()
> is returning an error, like it is effectively done when such a
> situation occurs for a domain not being the last one scanned.
> 
> Fixes: d046f361dc93 ("Xen Security Modules: XSM")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Should have finished reading the list first, before sending the same
patch again ...

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.