[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/6] iommu/arm: Introduce iommu_add_dt_pci_device API
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 2 May 2023 09:44:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZhG623XH/gq2heft254aHJTyUmLp/RiNpLTQb7PQSA=; b=QNr1C77pYQ1NecvL8LjmdFvoBlb65WbXRgIIktTvGLJah9K/zuzg8OoICWB3FtuLzGc5OINwIXDl1JydzToifnoO0b5EZIlKZvqYTIqhJaxNM8ijnJJyFDY0vSsVcsdJ+QuF9vkJ8pAgJGebQM/W9OYMxiVmmhrHvBHyAGdy6gkOV/23vuuuwl8Xx9an7Qx40nCT1iYSMT13honr5tJ85JqgYw0VT/R7jpZpOelTUwpyTtNdttPlSCoNB/toA/LH0Jt226TnIN2I9IGvvg5vzFwomfK7gOP43/ObTjy/cBPnshzDhnciLQxn4QXty+RXvEh5nkAUK/XkHKSK92zyOw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0MkeRvdBlHcdeXBcm35bwRiLFQPmolCJds6+9mWx3r1nXKu/kRdd90R1j3eENd8HrOqILcnVkUKeneMOFnSwlsDaI0CJcViI9iLwzTGMvb0E9GfmU+aRhFq6VM15RfUZSR5+FH/iAbrocdQPGrsJyIy9DgvhjeG1/0AnOCImfMKyTPkkuoQsc1waUWNy7/3WPgcuh6fxtAj2+1sT7UbXCEteYSwx3pQBdgBknupc6fiZv0qwGtOlZlf5MYJgyJ/8nMgknfbjrsyBPXJ0P7jRFwR+mNtgF9jFmBgMaEJIkrDy4cLr9X/WiJh8QU4PGnuJL8JiiEXe9yNntolXLpxHQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 02 May 2023 07:44:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.05.2023 22:03, Stewart Hildebrand wrote:
> @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d);
> * (IOMMU is not enabled/present or device is not connected to it).
> */
> int iommu_add_dt_device(struct dt_device_node *np);
> +#ifdef CONFIG_HAS_PCI
> +int iommu_add_dt_pci_device(uint8_t devfn, struct pci_dev *pdev);
> +#endif
Why the first parameter? Doesn't the 2nd one describe the device in full?
If this is about phantom devices, then I'd expect the function to take
care of those (like iommu_add_device() does), rather than its caller.
Jan
|
