[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/mm: replace bogus assertion in paging_log_dirty_op()


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 2 May 2023 12:20:31 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pb6iw5cLRiSuesUXK7CeQp6i3v2ou/42Org036m02Yk=; b=S8/4/DgxIfVfrL+NibJ1ygKKsLDQqYhXkPYIqyxzIj3coOwiCxii2VYBzt3WfGF1HkiZ/ZOtuPgfIDCBv+qDpbMxisZXrxrNfFLwAnS+3M+SiN1JAgCCmZi4ngtkiwU0AzU1gGyRueJW3giPn+enq98i+/6ZjI0nZg/r9TSAIpq+UeFQ39ZgNeuBCLo5ASuKGu88gdZEL2r5YqBrj1KjbORo5kilfAvEY7idrZwvawUjYYPkr0T32T6KXt62rBXprJWZjoYiiEpULmIu2uB3KLo35kIHjS81sRKpZOrVhuvICYBX4Bfy4zg3fCrk0kHFrj6YsPN3+rKzftwxQGY8yg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6/4yz/mBnEpw2zxwgYZIvgNZtvQ2q5nABzETJDF5P8tK/zRNMPprX+G0C3jvFdb/NuybslwByN1Gp3TXRfHkcE6Ej0GglL1+O39zKNFrBM5MEnXqX/mlhHnaEDKSbOLXqk+1oNjwkbNXOo1uBSq+DkOxo8GivxVjo8t614XlD+NgkSB1wtrNAyRD9kSf1Ny2E0lncQlt5aYOP5dsQSzg++00E2Sc6o7FoshTX63bzfrPUS8C5tSQ+wz3VVN0fb+RJKWQG6Eg2mD+/q0ijpb4bYoqsEdcPvEKXQ7DK7pC1FUWbJEAqxdCPKNuNXBZ56RD32tZKBpOR8MEzVTHJAzjw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Tue, 02 May 2023 10:20:59 +0000
  • Ironport-data: A9a23:Habe7a8MTkRijJFO+LkpDrUDp3+TJUtcMsCJ2f8bNWPcYEJGY0x3z DYcUT3TbvfeazHyc4txb9ixpBlSu8CAztVlGlQ++Co8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOKgR5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklVx 607BG5WVSykuP6o+rODFLVogJsseZyD0IM34hmMzBn/JNN+HdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTeIilAtuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37eezHKmCd1NfFG+3v10oW2u9mo6MwdMCnSCjeCouE/uVvsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluP1TM9KGYDYWoISFUD6ty7/IUr1EqTEpBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPeRENXCzAS58Ebuk
  • Ironport-hdrordr: A9a23:SxfA3KOoRp2gzsBcT4T155DYdb4zR+YMi2TDtnoBPCC9F/by+f xG88566faKskdsZJhNo7G90cq7MADhHOBOkOss1N6ZNWGNhILCFvAA0WKN+UyEJ8X0ntQtqp uJG8JFZOEZZjJB4voTL2ODfuoI8Z2/1OSNuM+b9nFqSGhRGtNdB8USMHfkLqWzLjM2dabQ0f Cnl7t6TkGbCBAqR/X+PGABQ+/A4/XTjfvdEGc7Li9i0hCKkTSrrJXnEx2Uty1uLg9n8PMZ6G 3YlA68wa2mv5iAu3jh/l6W1Y1ShNzijv1cA8CW4/JlTAnEu0KTfYF8XL/HhhAZydvfkGoCoZ 33uhI9OMY20X/LYW2vhhPo12DboU0Twk6n80acnXzg5fP0Xyg7Dc0pv/MiTifk
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Apr 27, 2023 at 02:29:06PM +0200, Jan Beulich wrote:
> While I was the one to introduce it, I don't think it is correct: A
> bogus continuation call issued by a tool stack domain may find another
> continuation in progress. IOW we've been asserting caller controlled
> state (which is reachable only via a domctl), and the early (lock-less)
> check in paging_domctl() helps in a limited way only.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.