Re: [PATCH v3 1/3] tools: Modify single-domid callers of xc_domain_getinfolist()

[Christian Lindig <christian.lindig@xxxxxxxxx>]

> On 2 May 2023, at 12:13, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx> 
> wrote:
> 
> xc_domain_getinfolist() internally relies on a sysctl that performs
> a linear search for the domids. Many callers of xc_domain_getinfolist()
> who require information about a precise domid are much better off calling
> xc_domain_getinfo_single() instead, that will use the getdomaininfo domctl
> instead and ensure the returned domid matches the requested one. The domtctl
> will find the domid faster too, because that uses hashed lists.
> 
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxx>

I mostly care about the OCaml bindings - looks good to me.

— C