[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][PATCH v6 15/19] xen/arm: Implement device tree node removal functionalities


  • To: Vikram Garhwal <vikram.garhwal@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 3 May 2023 10:02:04 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8XxwCWxGBDJ9HjygqjC1krQMtwlO2IPEWApQaNDq2/k=; b=hw4Om+hBEv1rQlltg6NlspKK4fq9dQkYU/MoConA7RP4HX5YPMMq5b4L3eviyP+C5F6CsX78KeRtYRaCPek9eLEWn/KPIGw3L9b+heWuYJGOWsGuZRUz49/Uz2DpsaqHNJ3Jgzj52dmX8ixbzV+7rsfikFCXeZlAvEQc1MQMAWhodmTYr6TrXtVxeEMhlMA2E37cOSNX6iCNSOtFKYkIg0hjV0zp9U1PKluHPHyEVmfhrag0kgjEned7D75I1sDJO4GNnbbzWQCe3pha1cT0UT/xH++X2OMg781oAbJC3U1eU/UOUrHJoOHqZhdyzg7kmoU4cSP+NqiPTCe4LC1XRw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmLCN5c06VUAzbyjhWOYR4eFmmS8TyCVRoJCKrCDV42a7R0YaJlMnC0hUwgfxIK3o1h6suRH1wP0dFup4lpIT+H+dbBDrWDc8JXI7D7hdxBKhuC4Xyng17i9Pd2vGi5aqKJNbNOP3X/Xd2LnxB+G5B6LUhw0VuElnW75pH0XJbJHGSjRRBj0bUy/WfRgw5qfwhaztVLli0fcT+LjjlrscwO/UMK6IfGodKnmxxMndk78c2p4B+lK9iDedYtPBlGYbK7tsWYNfzAWZpTY6rzHAj8Lq125ao3+UL+qPUJy+flyMDcnosTIbssTO6epSNmTUlpHbZCErNjsnIFL/ZZXBg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 03 May 2023 08:02:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.05.2023 01:36, Vikram Garhwal wrote:
> Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using
> device tree overlay.
> 
> xl dt-overlay remove file.dtbo:
>     Removes all the nodes in a given dtbo.
>     First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes
>     in dt_host and delete the device node entries from dt_host.
> 
>     The nodes get removed only if it is not used by any of dom0 or domio.
> 
> Also, added overlay_track struct to keep the track of added node through 
> device
> tree overlay. overlay_track has dt_host_new which is unflattened form of 
> updated
> fdt and name of overlay nodes. When a node is removed, we also free the memory
> used by overlay_track for the particular overlay node.
> 
> Nested overlay removal is supported in sequential manner only i.e. if
> overlay_child nests under overlay_parent, it is assumed that user first 
> removes
> overlay_child and then removes overlay_parent.
> 
> Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
> ---
>  xen/arch/arm/sysctl.c        |  16 +-
>  xen/common/Makefile          |   1 +
>  xen/common/dt-overlay.c      | 419 +++++++++++++++++++++++++++++++++++
>  xen/include/public/sysctl.h  |  23 ++
>  xen/include/xen/dt-overlay.h |  58 +++++
>  5 files changed, 516 insertions(+), 1 deletion(-)
>  create mode 100644 xen/common/dt-overlay.c
>  create mode 100644 xen/include/xen/dt-overlay.h

Is it possible that on the next patch I and other REST maintainers are Cc-ed
merely because at this point of introducing the two new files they're not
added to (perhaps) the DEVICE TREE section of ./MAINTAINERS right away?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.