[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds



Hi Jan,

On 03/05/2023 11:43, Jan Beulich wrote:
On 04.04.2023 12:40, Jan Beulich wrote:
On 04.04.2023 12:34, Andrew Cooper wrote:
On 04/04/2023 10:20 am, Jan Beulich wrote:
--- a/xen/arch/arm/include/asm/irq.h
+++ b/xen/arch/arm/include/asm/irq.h
@@ -52,7 +52,7 @@ struct arch_irq_desc {
extern const unsigned int nr_irqs;
  #define nr_static_irqs NR_IRQS
-#define arch_hwdom_irqs(domid) NR_IRQS
+#define arch_hwdom_irqs(d) NR_IRQS

I know it's not your bug, but this ought to be (d, NR_IRQS) as you're
changing it.

I can add this (with a cast to void), but I'll leave the final say to
Arm maintainers.

Arm maintainers,

may I ask for some kind of statement here? I'd be happy to follow
Andrew's request, but I don't want to then end up with an "unrelated
change" objection.

I am OK so long it is mentioned in the commit message.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.