[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V3 2/2] libxl: fix matching of generic virtio device


  • To: Julien Grall <julien@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 3 May 2023 14:27:49 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v9M5VZYtq+Ran5nYj9i4Y8tieuCE7epdLKj66oHAKeY=; b=T7pBL6CYiog40yzAKvYGpCwuEF1XzzfdiX05zzz7VFoIYaZBZ4OPVUxMOUggCNgFI5CDeyFrQYFcdNVMgAcLzkn5xY3F77b6Ka6ydFJUDkpRDyGrr/KmTn9OSty4o/A6snhzdcEQUvg48N7sll4fFtpbWr70Mz1sZ+aCOB/mFG7Mkqa8CpR733uas6kI0kiKCvHk9AHWoJew0iTFrwATyh1rCrmNrLyMONeLJNkmUULLjNZ2VcqmeehzJjepVUAtPU0kNgRH4lfMpqv/WCpQ3irGLSYsTtfxtBG0MhiUM7PFctkn/3R3LkWooiPj02a9Wj4fyaKHnE1/pnMXloNE9g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qw98ewXzUnygrXuCZH3fKbYbAOyfhIiRAnG382VjQ9OleHtRNZTm8EAyvwa77hlhiZE2HbSpWx4FBXpjVfsI44kGK9eUny1lf8g1ErYFd1eOfAPfo6c67Z4vdU/L4I3hJINQKwBhQnZsCrqn2v+SKAbVX1QQMbHV+DLDwKjHN6WwWKdFkjB5RvLg5vOax76LmXuXLUAz0y5YOVkob/IteEselgtyEZSYQBOank8tpUYNu6tutXLqUvWP/4++9woknm5Bfbs9qLRRsfvZtRMm7cd70AAXAdaFWNkRe8E7VCPzU52uRm0Gi7OIzWikfWIHFcx4UCZfJ/QCnJwuf0KlPA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>, stratos-dev@xxxxxxxxxxxxxxxxxxx, Alex Bennée <alex.bennee@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Erik Schilling <erik.schilling@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Viresh Kumar <viresh.kumar@xxxxxxxxxx>
  • Delivery-date: Wed, 03 May 2023 12:28:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.05.2023 14:04, Julien Grall wrote:
> On 03/05/2023 12:42, Jan Beulich wrote:
>> On 06.04.2023 10:58, Viresh Kumar wrote:
>>> The strings won't be an exact match, as we are only looking to match the
>>> prefix here, i.e. "virtio,device". This is already done properly in
>>> libxl_virtio.c file, lets do the same here too.
>>>
>>> Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device")
>>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>>> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>>
>> While I've committed the doc patch (patch 1), I don't think I should
>> commit this one without a maintainer ack, even if it looks pretty
>> straightforward. Anthony, Wei?
> 
> AFAICT Anthony has already given his acked-by:
> 
> https://lore.kernel.org/xen-devel/5e98d465-be8f-4050-a988-2a0829a71a2e@perard/#R

Oh, right you are. Thanks for pointing this out. And, Anthony: I'm sorry.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.