[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] tools: Use new xc function for some xc_domain_getinfo() calls
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 3 May 2023 18:02:58 +0100
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 03 May 2023 17:03:28 +0000
- Ironport-data: A9a23:sVtXLqhjwiauR/ZizUulX+AuX161dxAKZh0ujC45NGQN5FlHY01je htvWD3SOPuIZzHxLdB+btnjo0pTupPUndFiHlA/pChkECgb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QeFzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tREKiI3bjaIntiq0Y+fd/Uwo58JJcPCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XejtEqFWTtOwv7nLa1gBZ27nxKtvFPNeNQK25m27B/ zqfrjygWUFy2Nq3igOPrUiW2ObzvRjLZbwrCK+mq6A3nwjGroAUIEJPDgbqyRWjsWaiWtd3O 0ESvC00osAa/VSmVNDnUzWkoXSPuVgXXN84O+818gaW0YLP/h2UQGMDS1ZpeNEg8cM7WzEu/ luIhM/yQyxitqWPTnCQ/avSqim9UQAKKUcSaClCShEKi+QPu6lq0EiJFIw6Vvfo0JusQ2qYL y22QDYW27cBt84t3LyB4UH6pw+w+r2SZAc/z1CCNo661T+VdLJJdqTxtwiAta8afNnGJrWSl CNawpbDtYjiGbnIzXXQG7tVQdlF8t7faFXhbUhT847NHthH01qqZshu7T53Py+F2e5UKGayM Cc/Ve68jaK/3UdGjoctOepd8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFywfpnZ MzGKJz2VCZy5UFb8dZLb71Fje9DKt4WnAs/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0Z5oVD79q o4FX+PTkkU3bQELSnWPmWLlBQxQfCdT6FGfg5A/S9Nv1SI/QjF9V6OPnul9E2Gn9owM/tr1E riGchcw4DLCabfvd21mtlgLhGvTYKtC
- Ironport-hdrordr: A9a23:V982hairHaw8sVIoyQv8TIKZnXBQXlMji2hC6mlwRA09TyX4ra yTdZEgviMc5wxwZJhNo7G90ey7MArhHLROkO4s1NSZMzUOxlHYSr2KhLGKq1eMJ8S9zJ8k6U 4HSdkENDSaNzZHZKjBkXWFOudl7N6b8L25wcfypk0dMj2CspsQlTuR3Dzrb3FedU19CZ0lD4 rZw8xIqTa6EE5nDPiTNz0+U+/fvM2OsZTpbxIcQzsq9wWK5AnYjYLSIlyj0hACSCMK+Kwl8m TOjmXCl8aemsD+8BPaynTCq69bgd7wjuZEbfb87vQoFg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, May 02, 2023 at 12:13:37PM +0100, Alejandro Vallejo wrote:
> diff --git a/tools/libs/light/libxl_x86_acpi.c
> b/tools/libs/light/libxl_x86_acpi.c
> index 22eb160659..796b009d0c 100644
> --- a/tools/libs/light/libxl_x86_acpi.c
> +++ b/tools/libs/light/libxl_x86_acpi.c
> @@ -87,14 +87,14 @@ static int init_acpi_config(libxl__gc *gc,
> {
> xc_interface *xch = dom->xch;
> uint32_t domid = dom->guest_domid;
> - xc_dominfo_t info;
> + xc_domaininfo_t info;
> struct hvm_info_table *hvminfo;
> int i, r, rc;
>
> config->dsdt_anycpu = config->dsdt_15cpu = dsdt_pvh;
> config->dsdt_anycpu_len = config->dsdt_15cpu_len = dsdt_pvh_len;
>
> - r = xc_domain_getinfo(xch, domid, 1, &info);
> + r = xc_domain_getinfo_single(xch, domid, &info);
> if (r < 0) {
> LOG(ERROR, "getdomaininfo failed (rc=%d)", r);
You could change this error message. The value of 'r' isn't interesting
anymore. Instead, you could replace that by LOGE or LOGED (both will
print errno).
Otherwise, patch looks good:
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
