[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [XEN][PATCH v6 03/19] common/device_tree: change __unflatten_device_tree() type
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 4 May 2023 04:02:12 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XaxhynDBCTXoTSxI9Bm3w0rOkevBy3kSLJCJWr+icL4=; b=JfwDmKb2yj2jFnKWYzQn5JLrFxY2F9aFiP4TjaNoR+x/5NWH/7sNiMzBA2gEKkpaJhkMW3j2MMFDt0R6s0Flxomxlm2Scd4Uyo9DzO74+GAePCe+VeeEPv1gVV+B7wB9JSXmXfmzBci/ah+w9pwUWFsKxsQqCGJ/lRTtdVcMeJQnQj8pmUBpDFm464EeYW2KPc7qpKrYc8jrixmzsfV4+NlM1sBB46aGutndhlppVukRZMvpyxv/elgks7GoGnCanCnd6EX3Tg3GEw41cfp/DOlySyROkhW6ITClQiwX/amCP5/ZletCnNMpeIXDfhOOi9QfiXEnINju5prCKQ3Yrg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhLDA9ktPq2qbTYeY6WxJxZiRrFFqqXN4z/8sryUytfp/AjOeCkmzJXqgJCJmspHo3G9npsebVwKm8FDtSIVDyNDhLcVCJFGdvUYlLoCa/zndqpv6YS49VBnRqzpXALkLihLgJLOwAAn7hFFKX2kVtj4XuE3GyqQV7aLQaa6j/oK2lYT6W0z1LHAH5Kdgbi2sin1F6IF9og0vTvUEMsbH0ZU8DjWwBPe3An7E+dA4RbLOibeBb5n7JpJJLf41IEIYFu7WslWCN9AmrAFSuGBr3t0e+q536nxM0TF/64R5+M47iOK8lZr1eCNQg9K/ZYKMs7NkxgKDLcYM6XI6FYA/g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Thu, 04 May 2023 04:02:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZfU8eFkyMAUM1+keBcOFUYgl+f69Jf5iw
- Thread-topic: [XEN][PATCH v6 03/19] common/device_tree: change __unflatten_device_tree() type
Hi Vikram,
> -----Original Message-----
> Subject: [XEN][PATCH v6 03/19] common/device_tree: change
> __unflatten_device_tree() type
>
> Following changes are done to __unflatten_device_tree():
> 1. __unflatten_device_tree() is renamed to unflatten_device_tree().
> 2. Remove __init and static function type.
>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
I have a feeling that it may be better to swap the order between patch #2
and patch #3, so you won't need the extra name change in function
dt_unflatten_host_device_tree(). But this is my personal opinion and I think
the Arm maintainers are the people to do the final call.
Anyway this change looks good to me, either with the swap of patch order
or not, you can keep my:
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
