[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] restrict concept of pIRQ to x86
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 4 May 2023 09:50:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lv6nK4okzX9Eb24rzwqQlQtMHnW6zOzECXaBdXmSqh0=; b=FUDMwP3EvBs8q7nm4avNI8Xarpb5DVv3JXXTE0DSNTXtbbME9V6w0bvgUDAVEyIgdyOt+31slRNJeuTGIMkuesFss/m5apfj6ObKm4OfN80xmJzt9bLE6cChxbjvvsHRizDZ5OASTgQ0aWhY3irC53EsFVI1PpUwkhPz4VTSJtRXE8sYK9WI07cCYsBZJws6wZd1pbDcaC3FMMItqp0tzFAAi8yHyyHhj/RtrPciLz5mT+Sln3/2sQ4ZhRdh0QMCW+I1TX+g7PMtBHVWRkVjE95oGZsuMxbOXnWNqkGbVls4mVW4wViTdHriNY7YXoCFlDVcDiun9ju+dE8pp6j96A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JP0dg7emPWMFCbzQHGL/5yHAjo5qtmu6tZBzrdZuC554LjwQWcSc0cM45W5WCLtHDkyAPguUILVEHlsXSwRsUK9bcJ7qZG/NcY5O2Qtn6JSH3suwRqzBMkc2AI9hIEwpMWZYZfN75L5ZI2TxROXZz22zws58Jm1slf2L86fZJZ7DNVW1PstZU4VTnE+l2u5Zd3H8HsfIfiYcN+jd5tU/KhnWL+s+pfKfy9ovSXb16T/9RpqecZO86b1Mg0xSROAjCmUSHpTSe/3m9n0G91BqZ4zD4OzwzoECSwksonNh1PGa4tpfdaFnw8/V8L0LhM+OwruwB3YmNc0Ockhy3sAVJg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Thu, 04 May 2023 07:50:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.05.2023 09:44, Roger Pau Monné wrote:
> On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote:
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -438,12 +438,14 @@ struct domain
>>
>> struct grant_table *grant_table;
>>
>> +#ifdef CONFIG_HAS_PIRQ
>> /*
>> * Interrupt to event-channel mappings and other per-guest-pirq data.
>> * Protected by the domain's event-channel spinlock.
>> */
>> struct radix_tree_root pirq_tree;
>> unsigned int nr_pirqs;
>> +#endif
>
> Won't it be cleaner to just move this into arch_domain and avoid a
> bunch of the ifdefary? As the initialization of the fields would be
> moved to arch_domain_create() also.
That's hard to decide without knowing what e.g. RISC-V is going to
want. Taking (past) IA-64 into consideration - that would likely
have wanted to select this new HAS_PIRQ, and hence keeping these
pieces where they are imo makes sense. I did actually consider that
alternative, albeit just briefly. If that ...
> Maybe we would want to introduce some kind of arch-specific event
> channel handler so that the bind PIRQ hypercall could be handled
> there?
... and hence this was the route to take, I suppose I would simply
drop this patch and revert the 2nd one to what it was before (merely
addressing the review comment on Arm's arch_hwdom_irqs()). That's
simply more intrusive a change than I'm willing to make right here.
Jan
|
