[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v6 08/12] xen: dt: Replace u64 with uint64_t as the callback function parameters for dt_for_each_range()
- To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 4 May 2023 16:00:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N/o1q/uGkkgP51iWgzuz8DL/hnCZg7fL5E1OxJ1E/Cg=; b=JYi5wBt2HfiFLLEcFGjdC5YM/7sabVMHyJsg2nQ1JljkBWRvSvLlCuZr6/m36S4H/LYsjh2EaZDg/++b9W4jHupE3P4MMydb7yZxg/CoyEHOvqgC5m2+KvPbdQMJANfQKfCAdTKzd0LJxKSBWj21MZP6ekFa1HCQt2TANSaeb+SOPKh4J8WooulI7CsFtVBDHkPGkDz/U4WvNtPxfrWf9zb5zQv2Z/1i7wqVWjxJDBny9GVbOzh1uoiW59DrT7JT6h2/eNyZclzOZOuFyo6NSxJvlxXeAcdSKuUmRutV9si2BVCU1p/5LbtkkaCnnZRuSG0HpWSZ0gYiyjJVLU+5mQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ak0MoNIYap4A0M0CeK7zlTBhhTMgl1lWLzlB/vXKbhLFRULVAN9wdoGmKRwlc/v//0uAsPUE0YnmTi5Acklrqyf92wFi2IDaMk3gk9bOLqCQQSFL3YT/u2poem9NhVaQt/Y3j5sf1XIeiTeQgFpHuT6dh5vVc6FA0BlWVi1/zcQe3UkSAMZpgwJDZlFEBW1yY2lLy+crpzltlh6YTxKP0qIogQuj3RWBpa3BUo5cYnp93OP8xBMH21C/FiZ6emXQPIzffr1envQcUuXp3X7heBU4mfhQmTysO4qVB8MI+PhwPtwrKwOLeD+IH4g71JV0Bz1sIknYkH7V4fjHruPz6w==
- Cc: <sstabellini@xxxxxxxxxx>, <stefano.stabellini@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <george.dunlap@xxxxxxxxxx>, <jbeulich@xxxxxxxx>, <wl@xxxxxxx>, <rahul.singh@xxxxxxx>
- Delivery-date: Thu, 04 May 2023 14:00:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/05/2023 14:08, Julien Grall wrote:
>
>
> Hi,
>
> On 28/04/2023 18:55, Ayan Kumar Halder wrote:
>> In the callback functions invoked by dt_for_each_range() ie
>> handle_pci_range(),
>> map_range_to_domain(), 'u64' should be replaced with 'uint64_t' as the data
>> type
>> for the parameters.
>
> Please explain why this needs to be replaced. I.e. Xen coding style
> mention that u32 should be avoided.
>
>> Also dt_for_each_range() invokes the callback functions with
>> 'uint64_t' arguments.
>>
>> There is another callback function ie is_bar_valid() which uses 'paddr_t'
>> instead of 'u64' or 'uint64_t'. We will change it in the subsequent commit.
>
> I would rather prefer if this is folded in this patch.
>
With the Julien's comments fixed:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
