[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: shorten macro references
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 4 May 2023 18:24:02 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C7kpFIEGXAL2jxrg3WLBllXm2JX23q3dB1NJO/X8Mnc=; b=jlEL/uwZ4VptMluEOGnyn2xRwyQj/3Lps9kDuWM+yVduNAYZs7dQNOB3HrRA3Rd7wuTfNw/VDdoFfHw9CIIZsenb7REqxueJhPl9bnjoMCRt8+G1SDBKqDnIFjIIrhBwXxbsWGeID4w+EtkkXblKovuTi8UsiyXxAfDBikMCSbvrksg9lrJcWgtKeu57o+/9w0iJDSzfxdelTj5WFD+rLhzdzUkF2len1peE82yCgHMmop3d+fKrbdmr6bvCuY4XHBwIv0gzohR3Kr/lZHLkNPQYxNmMzp14L5VNa1+wY7ed0/FFvZ2EFwcFvNomwziY5Lwx39+1ydwy2VDMguafBg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+xUITIv/b/7R2/rcYufXXmyS0zOOPnkqUV8J4K48Nj+wCXxSS0oo3vV7/6J+33k/pTmwjysqXT1PbxwHMp3mlFvZW4qioW1IFdgiFDEYL3b1CPzxfysnBQDhYv1IWlKUaW4iwOv4vOoW0GUmWOc/diUt/9sBZmpzEyD+6CO2OcAPz0HVlV0s2g1R91jfFzo/rHwvkyA2MBpvvxAkv9AGzT37P+ryFMlH8YvrmNIB5bpBsBVoLLb9wr3m4eF0xkaZabOgZu0kk1P4ZdxTO9Zh5dBornXIk/ldhWEabsbxsNNiph0NYhwzJCxrtsDBsKf4FGmlUgpxCZeTX0q5nr/Jg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Bobby Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 04 May 2023 17:24:50 +0000
- Ironport-data: A9a23:Aenu8aDqpp8gJRVW/33jw5YqxClBgxIJ4kV8jS/XYbTApD0m3zdTm 2oZXjzVM6zeZ2H2edh/b9nipElTsZLVx4A3QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwwOpGH2Jny qQkKB8NMRnA1viq/+ilRbw57igjBJGD0II3nFhFlGmcKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+Oxuuzm7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXw32mCdtLTNVU8NYxsmK52F5QFCQTRAeQs6OTsne4eOBQf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaESoIKW4PYwcUQA1D5MPsyKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx750NisoM27S+7ErwiTumrZjUTSY4/gzSGGmi62tRboO/e5ah71Sd6P9aNZuYVXGIp n1CkM+bhMgECpuHhSGWQOEAGbivz/mAOTzYx1VoGvEJ/jCs4GKqfJoW7it3IkxoKe4bdTSva 0jW0Sta45lVO3mmZLF2eKq+Ds0rye7rEtGNaxzPRt9HY5w0cRDd+ihrPBaUxzq0yBlqlrwjM 5CGd8rqFWwdFals0DuxQaEazKMvwSc9g2jUQPgX0iia7FZXX1bNIZ9tDbdERrlnhE9YiG05K +piCvY=
- Ironport-hdrordr: A9a23:9YcdCq9gXQLyrNZh2c5uk+DEI+orL9Y04lQ7vn2ZKCYlEPBx9a iV9sjzsCWYtN9/Yh0dcLy7V5VoIkmslqKdg7NxAV7KZmCP01dASrsN0WKI+V3dJxE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04/05/2023 5:16 pm, Jan Beulich wrote:
> Presumably by copy-and-paste we've accumulated a number of instances of
> $(@D)/$(@F), which really is nothing else than $@. The split form only
> needs using when we want to e.g. insert a leading . at the beginning of
> the file name portion of the full name.
>From the Kbuild work, we have $(dot-target) now which is marginally more
legible than $(@D)/.$(@F), and we ought to use it consistently.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although ...
>
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
> $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o
> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \
> $(@D)/.$(@F).1.o -o $@
> - $(NM) -pa --format=sysv $(@D)/$(@F) \
> + $(NM) -pa --format=sysv $@ \
> | $(objtree)/tools/symbols --all-symbols --xensyms --sysv
> --sort \
> - >$(@D)/$(@F).map
> + >$@.map
... any chance we can get a space between > and $ like we do almost
everywhere else?
~Andrew
|
