[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 1/2] acpi: Make TPM version configurable.


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Jennifer Herbert <jennifer.herbert@xxxxxxxxxx>
  • Date: Fri, 5 May 2023 13:25:44 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CwCMoJsQ3XBHdfK27O+QOGL4OPl7EWw9dH3TIohe9kI=; b=WF1FrbqEZTA+JZu0SMPtipyKqTP6nqJVN0VkIKOWtSdSjA1Rp2t22Klwba4NWIXzBn+5N+99PBgdHVFElqmxGsWvxnJfH0bHyRDOWIqXOLUGyYAD9XpSWqqFlEQfNiLEptp9K6Ktmml8xoqmXjXYkqvVqq5VNhtJD/AuWhSJiiSaSGHkChfrERiGDZSRfvbf+ipA12dWYiTmiGkb37lnA6m7G5zhFVe6ghXciMTPPUM9xViXZr0PqzGLqbuDYm3qK3SL+7bgzNlf7MsphztptzFqg7H6MN8AJNi3r4FWY6LvaqQXzRm5di07n8hnWlUBlvx2aTvUZbQU61iSuNbG1g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ndFfZerHGfQZonnG8svWg05xeygl7bpXUNx09q8tBMbbpJOmH5kDSyBDzj5PnP9tcDSEdkDVY+uQIrLnly8Ix/vlVoFgmmhmDkSUDF7vXtBz6p1KyYm2ls8HpMk5gzwLggfL8M2ZAj0v0/wqRuTs/5RrmAYInMTTlv1CeA5PCzG3P87/MtNciA07wxywqXCqa6fWK4OBdZrwEz2+jjRBfWM6w071v30kbfjQvbQbs+9WG4wkOueMnxFMrNq0Cwd+6EVveSfyzZWbUZtP04d5FGtsAZPunvXCmLJpYrzI1cyG9MAgNWuX6LNjdnMwE6VZRtAsYIJy9JO479QSfU7MBg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 05 May 2023 12:26:14 +0000
  • Ironport-data: A9a23:XdW1ZqPd7AaeBUXvrR2RlsFynXyQoLVcMsEvi/4bfWQNrUor3mEDm GIeDGuDPqnYNGugKNAiOd/gpEoOsMPdy9E3Sgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gFmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0u9FPDgQ/ uw4FG82Yg6jq7yw3ZG6Z+Y506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzO7IA9ZidABNPLXd9qMRMtYhACYq 3jM8n7lKhobKMae2XyO9XfEaurnxHukA9hLSOPjnhJsqEaclnBKFC9NaUe6mN67qWP5ect8N lNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4qjd5QqDF3UHZjFEYd0i8sQxQFQCx lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJTbp+PHmqYA3yxfQFNBqFffvisWvQW2rh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7AJrVdl BDoQ/Sj0d0=
  • Ironport-hdrordr: A9a23:M3qxiKqMx5vAsCtg4qLc2M0aV5rbeYIsimQD101hICG9Evb0qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2Ki7GC/9SJIUbDH4VmpM VdmsZFaOEYdmIK6voT4GODYqodKNvsytHWuQ8JpU0dMz2DaMtbnnZE4h7wKDwReOHfb6BJbq Z14KB81kOdUEVSVOuXLF8fUdPOotXa/aiWHCLvV3YcmXGzZSrD0s+ALySl
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05/05/2023 07:34, Jan Beulich wrote:

On 04.05.2023 19:51, Jennifer Herbert wrote:
This patch makes the TPM version, for which the ACPI library probes, 
configurable.
If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be 
probed.
I have also added to hvmloader an option to allow setting this new config, 
which can
be triggered by setting the platform/tpm_verion xenstore key.

Signed-off-by: Jennifer Herbert <jennifer.herbert@xxxxxxxxxx>
Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit with two minor further request (which I'd be happy to make while
committing):


I agree, the NULL checks and tpm_verison initilizer are unnesery.
So I'd be very happy if you made these changes as you commit them!

Thankyou!


-jenny




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.