[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] LICENSES: Remove the use of deprecated LGPL SPDX tags
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 5 May 2023 14:36:02 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bgDkydVTkHtXCOHYGpAUhRwTNDLOWQG5oFcoYqgo3C8=; b=c2wPqybdovOExTebKFN+r+wZSeiFuN58g2iER84E+Dq6osX6PAE7vUJJwb3paZZdeemN+zSNxZHRNFT7t5RE7NxMKXfF9IVo/vDCYPT1X176LPGI4lxoGYtzQcukevLCMQmna4gCK8PAQRmNJAZeWCYXFvrVtdqnjqqp3uKR0PsnB9k6MlRwFo+kMnd4XfDfXYkBDB/Z0b7bueuiJR5eyzWiVk1RtHeixpoDzveYLJyOzMHEDU+ZeyH9FswXToqaHEtyohYckvlh+iZMFWdkms+/x6SNYOMlsXcTvH74CxBpnpYOv5uc7IInK2gipjjxyOU20rm0VWlmn8q7Jjr3XA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+UqyigkdsytwZkYLZn0zoyFmbgEMsh8CiXAyeOip4eNDpnBuP6Sfz67ovI/h6BbKPeak+lf69oiFZoIQJdXBLjh7seD7PLI89Ywct74Dtdt/a6yfZsIoZ+8Lr+LbnU/dt0vZIB9+0yT7EjvHg9vGjFwTMfrhjIoUr9O9QfmDqMvI63yDvAVDVPeCxI8KwwqM3Z3Nbrdi9aAvjRQLjPO9c8x8wUeQ1wH8rSWVX97+J97v2X3iXGKBchQxUuKHiBLCT1YXDtTJlgHEK3O0dTyrBrIj/o/GMP+U2ra/TyFwt7DzcvTAjtXoVpPzwzBw5jUDx9Q9mzOeXPAEEUOKeFcKw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 05 May 2023 13:36:28 +0000
- Ironport-data: A9a23:+ranJaAz53owRRVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApD9x0TdVm 2MeDGrTPviJYmf0c9skYYXg80hQ6sWHm9VhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5A4wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw1epQWURQz eMkGR8nRC6B29y5/++2Rbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xruQA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE37aXwX+kCNxLfFG+3txgp0+UzFINMzcxe36fvfCIiEGgVPsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ kCNt8PkA3poqrL9YXCA8raZqxuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH++E+dhTup/8LNVlRtul+RWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg==
- Ironport-hdrordr: A9a23:2wCszK4x0xaVxNEm5wPXwD7XdLJyesId70hD6qkQc3Fom6uj5q eTdZUgpHvJYVMqMk3I9urwWpVoLUm9yXcX2+gs1NWZLW/bUQKTRekIgeSN/9SKIVyaygcy79 YCT4FOTOTqC150lMD75xT9PeoB7bC8gduVrNab9mxqSw5ybaFm8kNeMSa0VmNLZCQuP+tCKL OsovNdoTyuYHIWadn+PHkKc/nIosHHmPvdEGc77zhO0njzsdpt0s+DYmWl4is=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/05/2023 2:31 pm, Jan Beulich wrote:
> On 05.05.2023 15:22, Andrew Cooper wrote:
>> On 05/05/2023 2:13 pm, Jan Beulich wrote:
>>> On 05.05.2023 15:05, Andrew Cooper wrote:
>>>> The SPDX forms without an explicit -only or -or-later suffix are deprecated
>>>> and should not be used.
>>> I guess this wants a reference to where this is specified. In particular ...
>>>
>>>> --- a/LICENSES/LGPL-2.1
>>>> +++ b/LICENSES/LGPL-2.1
>>>> @@ -1,5 +1,5 @@
>>>> -Valid-License-Identifier: LGPL-2.1
>>>> -Valid-License-Identifier: LGPL-2.1+
>>>> +Valid-License-Identifier: LGPL-2.1-only
>>>> +Valid-License-Identifier: LGPL-2.1-or-later
>>>>
>>>> SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html
>>> ... I can't spot anything like this under e.g. this URL.
>> Hmm yeah, it is irritating. The statement is at
>> https://spdx.org/licenses/ but only by virtue of two tables, the second
>> of which is the list of deprecated identifiers.
>>
>> I'll put a paragraph about this in the commit message.
>>
>>> Also is there a reason you add Deprecated-Identifier: only to GPL-2.0?
>>> Enumerating them would seem reasonable to me, not just for completeness,
>>> but also in case we end up importing a file with a deprecated tag.
>> We have problematic uses of GPL in tree, where we don't for LGPL.
>>
>> I'm considering a gitlab pass which will reject patches with use an
>> identifier not in the permitted list, and reject in introduction of new
>> uses of the deprecated ones. For this, the deprecated-but-tolerated
>> tags need calling out in some machine-readable way, but I don't think
>> it's helpful to express the tolerating of a tag we don't have any
>> violations of.
> Hmm, okay. With the expanded commit message
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks. FAOD, here's the full commit message with adjustment:
LICENSES: Remove the use of deprecated LGPL SPDX tags
The SPDX forms without an explicit -only or -or-later suffix are deprecated
and should not be used.
Somewhat unhelpfully at the time of writing, this only appears to be
indicated
by the separation of the two tables at https://spdx.org/licenses/
The recent changes to libacpi are the only examples of deprecated LGPL
tags in
tree, so fix them all up.
For GPL, we have many examples using deprecated tags. For now, just
identify
them as such and recommend that no new instances get added.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
