[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 5 May 2023 17:44:37 +0100
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxx>
- Delivery-date: Fri, 05 May 2023 16:45:04 +0000
- Ironport-data: A9a23:NSJfuKJ7iMxDYyKLFE+RW5UlxSXFcZb7ZxGr2PjKsXjdYENSgjUFm 2sYDGqEPPmLazajfNwnOoTg/EhQvpbdyt8ySQFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRjPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5UPVpz+ 6Q4MAtVVSiqhLKPmombE+hz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHZUNwhfD+ DuuE2LRWAsqK9DH8H28qlWI19TsuQn2W4YfLejtnhJtqALKnTFCYPEMbnOfvPKwzGC3XdlSL 0gJ0iM0qO4580nDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpQtE8qNU/QzBs8 1aThs7oHhRmqrjTQnWYnp+roDL0EigYK0cLfypCRgwAi/H5p5o5lBXITdBLH6u8j9mzEjb1q xiVqAAuirNVitQEv4258krAmCmEvYXSQ0g+4QC/dm6s8A5RfoOuYI2sr1/B4p5oKY+DS1Cbs Xssms6A7fsPB5WAiCyMRuoWGLijof2CNVX0iEZiBZA7+xyx+nSoesZb5zQWGatyGp9aI3mzO haV4F4PosYJZxNGcJObfaqSN/8Xw/DADe+9bcj9bYp3OKNRLQ6YqXQGiVGr44z9rKQ9ufhha czBLJf1VCly5bdPl2TvGbpEuVM/7mVnnD6IG8imp/iy+eDGDEN5X4vpJ7dnggoRyKqf6DvY/ N9EXydh40UOCbauCsU7HGN6ELzrEZTYLcqswyCvXrTfSjeK4Ul4YxMr/ZsvepZ+g4NenfrS8 3e2VydwkQSv3iedd1nTOyg4N9sDuKpCQY8TZ3RwbT5EJVB6CWpQ0EvvX8RuJuR2nACS5fV1U +MEa629Pxi7cRyeo251RcCk/ORfmOGD2Vrm09yNPGJuIPaNhmXhprfZQ+cY3HBRVXHo6ZFu/ eXIO8GyacNrejmOxf3+MJqHp25dd1BE8A6udyMk+uVuRXg=
- Ironport-hdrordr: A9a23:LOrwYqzUT4C4KCnOLoeWKrPw8b1zdoMgy1knxilNoH1uA6+lfq WV98jzuiWYtN98Yh0dcKm7SdW9qBDnlaKdg7N+AV74ZniFhILAFugLh7cKqAeAJ8SRzIFgPK 1bAs1D4PqZNykc/KCKmXjBL/8QhPqi+KCsify29QYWcegTUdAa0++mYjzrdnGffGF9dOcE/T Gnl7V6mwY=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, May 03, 2023 at 09:23:19AM +0000, Luca Fancellu wrote:
>
>
> > On 2 May 2023, at 17:13, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
> >
> > On Mon, Apr 24, 2023 at 07:02:45AM +0100, Luca Fancellu wrote:
> >> diff --git a/tools/include/xen-tools/arm-arch-capabilities.h
> >> b/tools/include/xen-tools/arm-arch-capabilities.h
> >> new file mode 100644
> >> index 000000000000..ac44c8b14344
> >> --- /dev/null
> >> +++ b/tools/include/xen-tools/arm-arch-capabilities.h
> >> @@ -0,0 +1,28 @@
> >> +/* SPDX-License-Identifier: GPL-2.0 */
> >
> > Do you mean GPL-2.0-only ?
> >
> > GPL-2.0 is deprecated by the SPDX project.
> >
> > https://spdx.org/licenses/GPL-2.0.html
> >
> >
> > Besides that, patch looks fine:
> > Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> Thanks, I’ll fix in the next push and I’ll add your R-by
Actually, could you use LGPL-2.1-only instead. As this code is to be
included in libxl, and libxl is supposed to be LGPL-2.1-only, it might
be better to be on the safe side and use LGPL for this new file.
As I understand (from recent discussion about libacpi, and a quick search
only), mixing GPL and LGPL code might mean the result is GPL. So just to
be on the safe side, have this file been LGPL might be better. And it
seems that it would still be fine to include that file in GPL projects.
Would that be ok with you?
Cheers,
--
Anthony PERARD
|
