[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] x86/cpuid: Rename NCAPINTS to X86_NR_CAPS
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 8 May 2023 08:55:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hdXLfsRIT6/1HTTPg8tyCJ0DN0VEt440lgmkVWRuqeU=; b=ErCFIrqiKqTl6RoSOYfx8ysqF+qynuoa/qwuda6IuT76rZyVK+trviGIhiyL5wVM9aJbflHVk1OxQv/ltSlSQc+mA78N37q0lbJMHo3/CZvnXb9DUanS65jzEGDh3jHSM7QeUJzXJuFVyElsRS4uu3AOZc1pt3PBjQlEym29PKunmudHkJBkcDlsODEHN5jKCPydcfZC1FuWZWhRaDsvGc+wzUdXq7UBu/146lCSWgNJFdKfbC05uBkK+Nrbf1ACctwNnNpdlbSdE+a+wwowLQHvSF5dCc/WypQ8EC6yIbcOJBTcw3Oqx5Pim9pYDHCWcZAynB0laBhkArL0EqMycw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UEy0RALmbGAB2alOZ96cfOKjYLBmaJMbhZLd4zkShaRW7sx7YPzsa6UGPZfCgBV7yYn8PxaC/MiWVE8jWLv0YfKmlVau817fixqvwfw86tYf7d4pcJQ8iG4XYqxd0XGngoE3nZbwa9LEsTZteZ+ri2+AVT2aP6yihGBNnoLeH2wqrp6P0Eqk9vq/EdTOgT/kjk8vtgti4hX1me6grATIc7IBzQwBiM9peEnJF4WoCjzAtLUWErlJrA1m89WubbS7+ZVoJsO8oW1IGlSe8w224PkdEIepj4KKnRFV+b3RGIARnZ1v7BkET1yLWHTC4j4c/VecFv0/HqFineC9B2apbA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 08 May 2023 06:55:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.05.2023 21:39, Andrew Cooper wrote:
> The latter is more legible, and consistent with X86_NR_{SYNTH,BUG} which
> already exist.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I can live with this as-is, so
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
yet ...
> --- a/xen/arch/x86/include/asm/cpufeatures.h
> +++ b/xen/arch/x86/include/asm/cpufeatures.h
> @@ -53,4 +53,4 @@ XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /*
> MSR_PRED_CMD used by Xen for
> #define X86_BUG_IBPB_NO_RET X86_BUG( 3) /* IBPB doesn't flush the
> RSB/RAS */
>
> /* Total number of capability words, inc synth and bug words. */
> -#define NCAPINTS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words
> worth of info */
> +#define X86_NR_CAPS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit
> words worth of info */
... the way the value is computed suggests to me that "CAPS" (i.e.
"capabilities") isn't quite the right term. "features" sadly isn't, either
(or else I'd have suggested that without hesitating), as neither of the
two really fits the inclusion of "bugs", but feels - to me as a non-native
English speaker - still slightly better.
Then again "CAPS" fits x86_capability[] best ...
Jan
|
