[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Fix install.sh for systemd


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Tue, 9 May 2023 15:19:02 +0200
  • Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1683638349; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=rpuULCw5A7ilt2bXrFeg0Vy8Af4vXwqUM0zRdW+DNBM=; b=Mgk9WGkXHV45+gDRCXJoqNsLz0r4mz1JWNfXseGYkesIOojnVIaV+/WU1J8AfDBbj2 3zsZIL0ENyUfX10mt8gAeUgl6aPBrIz10/rxj96M31EeDF4AMHRDnpmxoAmrb/yxeBU1 Z6wUWoRJ3blFrreD3nzMLB8JmJ9ZNGho+hlmHCpWdVPySl+aEtdjHuh8pdXCmIk77gAX kcE/GXJI1qqj+cHLWKkhSojILDAfb0xbdj9LFmEXlaWp3MLbp3EPWGyFdLionrvP+PMH pn1NkQIxBDpb1/CAWgtCYik8Rdzq7Lq+MX1JPNxNhSxfk+mKjXHF2AA50Kt/4J3aVyD6 +XAg==
  • Arc-seal: i=1; a=rsa-sha256; t=1683638349; cv=none; d=strato.com; s=strato-dkim-0002; b=GRiBNU2amoEyyJJhmK5Is9uO3Ekfn8meC6iqfYwqjOijRLCZYAhNuju6sKXtBpi5Sj mKc9Ss7O5jYYaJvxyRanUNnBfswav+UvEinVP0MnSqA8Tgc5hSrtSWfhw3wHlBA72NOF jReajvxj4YomOfuAXXDcqCST33uuzkm04A48BMhr5Lk3l3zdCLBievNV+s29UyCirse+ JBIcT8OwY7+Zub4y5sEkAY9R25rV82GYrBl97fRHfnMrjB5yMVcMSFbzbePQXrtNrAEu dgWJwVZVvd6u7C6aeNri5j50Y2SkJlWCQ4rdIUwWXXthzSM+gsB6SBtAnhHvRYrXH2zP HTCw==
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Jason Andryuk <jandryuk@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Tue, 09 May 2023 13:19:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Tue, 9 May 2023 13:47:11 +0100 Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:

> > +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in
> > @@ -49,6 +49,7 @@ fi
> >  
> >  do_start () {
> >     echo Starting xl devd...
> > +   mkdir -m700 -p @XEN_RUN_DIR@  
> 
> Why is this 700, and the others just using regular perms?

I think the permissions are just copy&paste from elsewhere.
I have to check why -m700 is used anyway, and why it is not used consistently.

> Also, doesn't it want quoting like the other examples too?

There is a mix of quoting and non-quoting. Not sure if having spaces in any of 
the path names does actually work today.

I will double check this detail as well.

Olaf

Attachment: pgpcQJHBQjrIF.pgp
Description: Digitale Signatur von OpenPGP


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.