[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] docs: document ~/control/feature-balloon
- To: Yann Dirson <yann.dirson@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 11 May 2023 11:21:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jBY1Gs29LACMSjd3zFO4liO1LG+k66su+TGcjyEQdNA=; b=BQ84eOKwUsSb2tDq8Jg+pvRVXn1u6MOrVxVZiFm4i5lpIDvnb70an0XhkmTN/KkDZydGWrfhfUUofbQMc2jYu8JnbfwgfrkrNYGYuuMlmeTkvDyfDVq8671jRO/mLmoFW8e/qn5dLYr4F3djXN62DPMmdNDgYL2XAZI8D0iqs3b75BWjRibphhZdDNF/S/bD4yVDPcWHV/m4LOjLnIunjiglwhrNmWm5nb7NfBu2OoXRdHXmMGIACidCWxo/U2TXEvVKsxNpBWNnGjRYFMV+xWw/6XIs/GsF7In07C6dOEVGqv9cu1XMa6+EdW+N93G/U/vb0HOlOw4oWO8XMfeFSw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTUKtgGV2RV7tKZxj/riMk5gC+KJiA7Oc7EbhZ9iINtujobNr2HB+aA/291H+aObW59UM5xXj54xjITqF3QvQViSwsr45lmEjlxxonuoTMzDvWrA9a/0c4gBBlvJ6yRsRUlOcBMb+4hKhAt+ISd9aDJ59UURDz7CvjpNlZbKLr5w0Fli2dbghABt4ztxqYyNy/oKITMqkmQPQi+ROv55Cqoe+f1Z6ePmwwz6uXYqjoIZK4gdLtxSLt8b/sg6wISwTSucSsSibKMTAt5f9MLSKDhRl7O9BfzgRD0LdyxtIezEnCT33m53EMWdybS6bT1omWH8IMsItl84SGEOandh0A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xihuan.yang@xxxxxxxxxx, min.li1@xxxxxxxxxx
- Delivery-date: Thu, 11 May 2023 09:21:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.05.2023 16:20, Yann Dirson wrote:
> --- a/docs/misc/xenstore-paths.pandoc
> +++ b/docs/misc/xenstore-paths.pandoc
> @@ -509,6 +509,12 @@ This may be initialized to "" by the toolstack and may
> then be set
> to 0 or 1 by a guest to indicate whether it is capable of responding
> to a mode value written to ~/control/laptop-slate-mode.
>
> +#### ~/control/feature-balloon
> +
> +This may be initialized to "" by the toolstack and may then be set to
> +0 or 1 by a guest to indicate whether it is capable of memory
> +ballooning, and responds to values written to ~/memory/target.
Besides correctly saying "may", I guess this wants to go further and also
clarify what the (intended) behavior is when the node is absent. Aiui PV
guests are always expected to have a balloon driver, so the assumed
value likely needs to be "1" there. Furthermore I'm afraid it doesn't
really become clear what value this node is if it's only optionally
present, while its absence doesn't really allow uniform assumptions
towards a default value.
Jan
|
