[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iommu/amd-vi: fix assert comparing boolean to enum
- To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 11 May 2023 15:55:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iLzNp0Uil+lUeDT7rXJ7JiIdPzmdObHlI3GyQ34QU7o=; b=VgInGmBUxhkPhXJBT2Q62M4/Notk3s6aOh90wACw2+6FrpyNBzNkeepkrOOZL+2EHODQ1wroaCsbsgFIFLcFG/jl+vp/yPCgxRa+Uk3n6pTZtg8qELgOXj/R3wumc7wYgW75IuuII54YzVroMZv9kN8c139yvdViWVs2q3mTb1BJz1K/bGufjcc0lum5yMXyHLGLMmO2NywPoLZmiim238jFEn+rZRnJ0TJh+lanWh8ZcjtW1uwnNfymnWp+CTCIevoFeZcgqYXlUTcTX1ZbpaisD8cmX7tOfgrOKZYOC6iJFv99DbSUk0dX6yW2s2n7VhWTkGuiIIqjy2+QEvOHrQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=McbQrTMfkEtpM4g5V0BJM4Clv0EJSx7LJKcSl+cb51bMuyUfKGfspXpk0fTXozSwkML0XDAatMJzk01tOG9C+6v0ZolQsnEBe3EidREew3h1YVYVLnFV5x0LeVMjYVKfSNhgMMKExIaT6ZK4mQehVmF5DejGqZx/Rr4sjDaVVDa5DbDNZBPad6Y2iLCi2PtfdWzMyagZkLvv6vjDvU0TOqOs67eGpZKyYr7sHiARNxGKuan4EySZqyjNNkV78FUSm2eP/WghE6Wqn3uQdPT3DeNEkqJySD5W4Yu1tMIN4n4BpaZ+npQuEATVF6yABCHq292TyeXV3wEM1omA+ojU8w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 11 May 2023 14:55:38 +0000
- Ironport-data: A9a23:8oDHEaAchVX21hVW/zfiw5YqxClBgxIJ4kV8jS/XYbTApGshgzdVm 2UWWWmHMqmOMTb9eNsjaYq+8E0A65SEx9BrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G5B5wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwo+NsM0tg3 McieT0nPz/evfmv+427c7w57igjBJGD0II3nFhFlWucIdN9BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xrsgA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE37efxXqrCNNCfFG+3twpjlehwV4KMycxTHCpouOerHOnVusKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRSXKa9THuc8vKYqGi0MC1Nd2saP3dYHE0C/sXpp5w1glTXVNF/HaWpj9rzXzbt3 zSNqyt4jLIW5SIW65iGEZn8q2rEjvD0osQdvG07gkrNAttFWbOY
- Ironport-hdrordr: A9a23:135BXaCFXQRPDA/lHemW55DYdb4zR+YMi2TDsHocdfU1SKOlfq WV98jzuiWbtN98YhAdcLK7Scu9qALnlaKdiLN5Vd3OYOCMghrKEGgN1/qE/xTQXwH46+5Bxe NBXsFFebvN5IFB/KPHCd+DYrId/OU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/05/2023 3:53 pm, Jan Beulich wrote:
> On 11.05.2023 16:51, Roger Pau Monne wrote:
>> Or else when iommu_intremap is set to iommu_intremap_full the assert
>> triggers.
>>
>> Fixes: 1ba66a870eba ('AMD/IOMMU: without XT, x2APIC needs to be forced into
>> physical mode')
>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
It occurs to me that this might be related to the reports we're still
getting of some problems on these systems...
~Andrew
|
