[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] xen/arm: domain_build: Propagate return code of map_irq_to_domain()
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx, Michal Orzel <michal.orzel@xxxxxxx>
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Thu, 11 May 2023 16:20:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AwKN5ctfo4h345rsU1a5vyrdU45foxlxf5zSETQJSko=; b=L8BVRObG0QwtYAOlc4K7jYObI1g0NnqIh/d5YdN0RGXxusa7lvQrQFq1s0M/L1YxlI7qj6Qy3s8ShlQHo64JjsEs75hD39PxZipvx7DnePDAIHmYkH9YWQI0IhJF7Q7UHqsYay28thxOuFQFTh8m6OgdmbyuaHRTQZyo22e/H3PWMfNdzuvByST+7p5wEb+xq2NmFfQKZkLGuDPvI/U0emESLupgHmSYRp00JK3nbqWqO2/lcEMmIYl/gEIMVXhvuqTymH3BSkhH0/8yFlKg9neGdVUBZKkp2IwQYOdpljZrurHUUTmtBvCEYFNyzQnLNT2xw4HTK0bZ7y0vSyBufA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g87zleXaVIEW4oaBKiY0RkQyXilG8X1j19Nj9KZCm2RGp5XU0Y214yXzO6TSR82e/dgDr2aIpPTcWT3w82bljnEsRPHSlS6eyuXkjpwnfEQlXVdyTRc4ubRyBsVPRht1QmjS9unG8b1I+WkcHJwcxqHvJlPzwUDdrMsb2b/hZtwzcr1Dyo6tMg/9+xoB3104dADcR8zI8MgVpBZLaKcDZ8beEonozhoi3MBf4dFCQz0PXVFb1BLmlLeA0ZSZCtN5GLnAUFmQzwSOkpo1ZPHTDzAMhZoQh8uXwfjaip5l+dkeoSK9ckjj//mIK9XW/dpymVWRHsXelHi0J6zIETSX6w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Delivery-date: Thu, 11 May 2023 15:21:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/05/2023 14:02, Michal Orzel wrote:
From map_dt_irq_to_domain() we are assigning a return code of
map_irq_to_domain() to a variable without checking it for an error.
Fix it by propagating the return code directly since this is the last
call.
Fixes: 467e5cbb2ffc ("xen: arm: consolidate mmio and irq mapping to dom0")
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
---
Changes in v2:
- split the patch so that a fix alone can be backported
---
xen/arch/arm/domain_build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index f80fdd1af206..9dee1bb8f21c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2320,7 +2320,7 @@ static int __init map_dt_irq_to_domain(const struct
dt_device_node *dev,
res = map_irq_to_domain(d, irq, !mr_data->skip_mapping, dt_node_name(dev));
- return 0;
+ return res;
}
int __init map_range_to_domain(const struct dt_device_node *dev,
|
